cloudiscovery icon indicating copy to clipboard operation
cloudiscovery copied to clipboard

Refactoring Cloudiscovery CLI to support [provider] [resource] format

Open jacorbello opened this issue 4 years ago • 6 comments

The purpose of this PR is to refactor the CLI to support multiple cloud providers. The changes proposed here will provide benefits in the following manners:

  • The argparser has been updated to nest subparsers under cloud providers
    • (aws | az) (vpc | security | etc.)
  • Allows for future standardization of resource arguments (not part of this PR)
    • Instead of provider-specific resource calls, generalize them:
      • cloudiscovery aws network --vpc-id vpc-xxxxxxxx
      • cloudiscovery az network --vnet-name my-vnet

Note - This is a breaking change for any automated implementations of Cloudiscovery. Commands such as aws-vpc and similar are no longer supported in this refactor.

This is to be the first of a series of pull requests to begin enabling multi-cloud provider support.

jacorbello avatar Feb 09 '21 02:02 jacorbello

Hi @jacorbello! Thanks for this PR! I'll try to analyze it tomorrow, ok?! 🤟🤟😃😃

leandrodamascena avatar Feb 10 '21 01:02 leandrodamascena

Nice work! 👍🏻

gentleadam avatar Feb 12 '21 09:02 gentleadam

I need to check circleci build, I think it crashed. Checking now.

leandrodamascena avatar Feb 13 '21 09:02 leandrodamascena

I need to check circleci build, I think it crashed. Checking now.

Might have been the change in version number, I forgot to update the git tag as well. Just updated that and pushed the tag up. Maybe that'll help? 🤷

jacorbello avatar Feb 14 '21 12:02 jacorbello

I need to check circleci build, I think it crashed. Checking now.

Might have been the change in version number, I forgot to update the git tag as well. Just updated that and pushed the tag up. Maybe that'll help? 🤷

Hii.. I was full of work last week, but this week I'm focusing in cloudiscovery! Let me fix this PR to merge!

leandrodamascena avatar Feb 22 '21 18:02 leandrodamascena

Hey @leandrodamascena, just checking in. Anything I can do to help with this PR?

jacorbello avatar Mar 08 '21 14:03 jacorbello