closure_tree icon indicating copy to clipboard operation
closure_tree copied to clipboard

support for integer order_column with not-null constraint

Open nruth opened this issue 7 years ago • 4 comments

Currently I'm getting null values inserted, then I assume updated afterwards, which gets rejected by postgres if there is a not null constraint.

On removing the not-null constraint, I see created records being given positions (order_column) correctly, but I'd prefer not to remove the constraint.

Is there a way to improve this, or could it be documented that it's not supported & perhaps suggest something else like a deferred trigger and transactions in place of a not-null constraint?

nruth avatar Feb 19 '17 14:02 nruth

It seems absolutely reasonable for this to be supported.

Would you be willing to work on a PR? I'd be happy to review it.

mceachen avatar Mar 02 '17 05:03 mceachen

Yes certainly, I will try to make time for this soon.

On 2 Mar 2017, at 06:33, Matthew McEachen [email protected] wrote:

It seems absolutely reasonable for this to be supported.

Would you be willing to work on a PR? I'd be happy to review it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

nruth avatar Mar 02 '17 13:03 nruth

Quick update: I've asked a colleague to work on this. I'm aiming to review and send a PR within the next few weeks.

nruth avatar Mar 10 '17 15:03 nruth

Any updates here? I too would like to have this. Could contribute work if needed.

smoyte avatar May 29 '18 19:05 smoyte