closure_tree icon indicating copy to clipboard operation
closure_tree copied to clipboard

Second hierarchy migration fails due to index name clash

Open rcanand opened this issue 11 years ago • 6 comments

I use closure tree to create hierarchies for two models in my app. The first one succeeds, but the second one fails, due to the generated index name conflict ("anc_desc_idx" and "desc_idx") . Renaming these indices to be model specific ("tag_anc_desc_idx" and "tag_desc_idx", for instance) is a workaround. Expected: The index name generated to include the model name to disambiguate indices across models.

rcanand avatar Oct 13 '14 09:10 rcanand

The bug was introduced in https://github.com/mceachen/closure_tree/commit/d0406408fb326b08ec3b86f379f957ce7692ec28#diff-1b9222a399a8e5870dd9f6852b9c1c27

@mceachen , we should fix this.

seuros avatar Oct 13 '14 09:10 seuros

@rcanand do you mind sending a PR ?

seuros avatar Oct 13 '14 09:10 seuros

@rselk, do you want to take a stab for this fix ?

seuros avatar Oct 13 '14 10:10 seuros

I'll be able to do a patch release tonight with a fix. Thanks for reporting the issue!

mceachen avatar Oct 13 '14 15:10 mceachen

(To clarify, I'll pull your branch when you've got it ready)

mceachen avatar Oct 13 '14 15:10 mceachen

pr sent for this https://github.com/mceachen/closure_tree/pull/129/

rselk avatar Oct 13 '14 23:10 rselk