mobileraker_companion icon indicating copy to clipboard operation
mobileraker_companion copied to clipboard

Persistent Notification for Progress

Open AlfonsoDehesa opened this issue 2 years ago • 6 comments

Not sure if this is the repo to add this in, or if this repo includes the app, but would be super cool to have a persistent notification with progress % and ETA instead of getting 20 notifications at each 5% at the most granular. I think Octoapp has an example of this for octoprint setups.

AlfonsoDehesa avatar Jan 12 '24 18:01 AlfonsoDehesa

Hey, I assume you are talking about persistent progress notifications on Android?

It is on my ToDo list, as this was one of the features that I sadly had to remove due to a change in a library. However, luckily the library finally supports these kinds of notifications again. I just have some other stuff to work on right now.

Clon1998 avatar Jan 12 '24 20:01 Clon1998

Makes sense! Thanks for the quick reply.

AlfonsoDehesa avatar Jan 12 '24 22:01 AlfonsoDehesa

I can open an issue for this, but based on commits recently and my log file, it looks like this always making things a progress notification unless its a defined event like start, stop, error?

Is this intended behavior now and the % selection in the application doesn't control anything anymore?

image

https://github.com/Clon1998/mobileraker_companion/commit/e952712ec6f290d840f75dc86f5c66450e49d45f

Even if i set my App to use 5% it still seems to use the new notification type? Screenshot 2024-02-28 210948

fuzelet avatar Feb 29 '24 02:02 fuzelet

I can open an issue for this, but based on commits recently and my log file, it looks like this always making things a progress notification unless its a defined event like start, stop, error?

Is this intended behavior now and the % selection in the application doesn't control anything anymore?

image

e952712

Even if i set my App to use 5% it still seems to use the new notification type? Screenshot 2024-02-28 210948

Hey, are you using Android or IOS? On Android, the Progress-Interval option has no effect anymore except if you disable it. While on IOS you should only get notifications in your defined progress interval

Clon1998 avatar Feb 29 '24 09:02 Clon1998

Appreciate the information. I am using the android application from the play store in the "beta" sign up. I have noticed that I am also no longer get images with these new notifications as well. I seem to only get images when it's an event now, like start, end, error. Is that part of the new change as well?

Screenshot_20240229-074828 Screenshot_20240228-202937

fuzelet avatar Feb 29 '24 12:02 fuzelet

Appreciate the information. I am using the android application from the play store in the "beta" sign up. I have noticed that I am also no longer get images with these new notifications as well. I seem to only get images when it's an event now, like start, end, error. Is that part of the new change as well?

Screenshot_20240229-074828 Screenshot_20240228-202937

That is a good point. I might have forgotten to include the snapshots. I will verify if that is even possible. If it is possible I will make sure to update the companion. Otherwise, I will include an option to configure the notification type (Either persistent progress or the text-based)

Clon1998 avatar Feb 29 '24 13:02 Clon1998