mobileraker
mobileraker copied to clipboard
Enhance 'Output pin' behaviour
-
Currently for output button we have got slider, even if it have only two positions
-
Could you please add ordinary button (on /off) , if output pin can take only two values?
-
Example from Fluidd
Thanks!)
Adding such an option should not be a problem. I'll add it once I am done migrating to a new framework.
Adding to this: could the slider actually enable values between 0 and 1? I got a Daylight on the pin and can only do off/max brightness instead of changing the brightness.
Adding to this: could the slider actually enable values between 0 and 1? I got a Daylight on the pin and can only do off/max brightness instead of changing the brightness.
Hey, this depends on the output pin scale
configuration. Make sure you set the configuration correctly to enable this!
@willkaxxx sorry for my WAY to late reply, I just went trough the issues and was wondering why this ticket is not closed yet since I implemented the logic for this ages ago. Turns out the config parsing for the output_pin
was not working correctly causing the app to still use a slider instead of the new switch cards!
I included the fix in the upcoming version 2.3.0
!
Added in 2.3.0
Adding to this: could the slider actually enable values between 0 and 1? I got a Daylight on the pin and can only do off/max brightness instead of changing the brightness.
Hey, this depends on the output pin
scale
configuration. Make sure you set the configuration correctly to enable this!
Hey, will try scale
when home, but shouldn't this also work if I got PWM enabled? I can already change the brightness in Mainsail.
Hey, @Clon1998 , I have tried to reinstal app, clean cashes, delete printer from configs.
But it still a slider :(
Could you suggest something to try more?
My current version is 2.3.1
My config in klipper like:
Thanks
Adding to this: could the slider actually enable values between 0 and 1? I got a Daylight on the pin and can only do off/max brightness instead of changing the brightness.
Hey, this depends on the output pin
scale
configuration. Make sure you set the configuration correctly to enable this!Hey, will try
scale
when home, but shouldn't this also work if I got PWM enabled? I can already change the brightness in Mainsail.
Good point, I will make sure that non pwm pins are always toggles/switches.
Hey, @Clon1998 , I have tried to reinstal app, clean cashes, delete printer from configs.
But it still a slider :(
Could you suggest something to try more?
My current version is 2.3.1
My config in klipper like:
Thanks
Hey,
I will check that. The pin I tested that with is defined like that
@willkaxxx, I just had another look and I simply can not reproduce this on my device (version 2.3.4).
See my test config:
@Clon1998 I have found the root cause, if name of pin is "LED" (upper case), it doesnt work as expected, but if I change naming to "led" (lower case), it works fine
@Clon1998 I have found the root cause, if name of pin is "LED" (upper case), it doesnt work as expected, but if I change naming to "led" (lower case), it works fine
That's interesting and definitely a Bug in mobileraker. I will double check my implementation. Thanks for your reply!
I forgot to close this issue. The parsing for most klipper objects was reworked and the keys/config keys are now case-insensitive.