mobileraker icon indicating copy to clipboard operation
mobileraker copied to clipboard

Enhance 'Output pin' behaviour

Open willkaxxx opened this issue 2 years ago • 1 comments

  • Currently for output button we have got slider, even if it have only two positions image image

  • Could you please add ordinary button (on /off) , if output pin can take only two values?

  • Example from Fluidd image

Thanks!)

willkaxxx avatar Aug 21 '22 10:08 willkaxxx

Adding such an option should not be a problem. I'll add it once I am done migrating to a new framework.

Clon1998 avatar Aug 21 '22 23:08 Clon1998

Adding to this: could the slider actually enable values between 0 and 1? I got a Daylight on the pin and can only do off/max brightness instead of changing the brightness.

Fl0ken avatar Apr 25 '23 14:04 Fl0ken

Adding to this: could the slider actually enable values between 0 and 1? I got a Daylight on the pin and can only do off/max brightness instead of changing the brightness.

Hey, this depends on the output pin scale configuration. Make sure you set the configuration correctly to enable this!

Clon1998 avatar May 19 '23 17:05 Clon1998

@willkaxxx sorry for my WAY to late reply, I just went trough the issues and was wondering why this ticket is not closed yet since I implemented the logic for this ages ago. Turns out the config parsing for the output_pin was not working correctly causing the app to still use a slider instead of the new switch cards!

I included the fix in the upcoming version 2.3.0!

Clon1998 avatar May 19 '23 17:05 Clon1998

Added in 2.3.0

Clon1998 avatar May 19 '23 22:05 Clon1998

Adding to this: could the slider actually enable values between 0 and 1? I got a Daylight on the pin and can only do off/max brightness instead of changing the brightness.

Hey, this depends on the output pin scale configuration. Make sure you set the configuration correctly to enable this!

Hey, will try scale when home, but shouldn't this also work if I got PWM enabled? I can already change the brightness in Mainsail.

Fl0ken avatar May 20 '23 09:05 Fl0ken

Hey, @Clon1998 , I have tried to reinstal app, clean cashes, delete printer from configs. But it still a slider :( Could you suggest something to try more? My current version is 2.3.1 My config in klipper like: image

Thanks

willkaxxx avatar May 21 '23 15:05 willkaxxx

Adding to this: could the slider actually enable values between 0 and 1? I got a Daylight on the pin and can only do off/max brightness instead of changing the brightness.

Hey, this depends on the output pin scale configuration. Make sure you set the configuration correctly to enable this!

Hey, will try scale when home, but shouldn't this also work if I got PWM enabled? I can already change the brightness in Mainsail.

Good point, I will make sure that non pwm pins are always toggles/switches.

Clon1998 avatar May 21 '23 15:05 Clon1998

Hey, @Clon1998 , I have tried to reinstal app, clean cashes, delete printer from configs.

But it still a slider :(

Could you suggest something to try more?

My current version is 2.3.1

My config in klipper like:

image

Thanks

Hey, I will check that. The pin I tested that with is defined like that image

Clon1998 avatar May 21 '23 15:05 Clon1998

@willkaxxx, I just had another look and I simply can not reproduce this on my device (version 2.3.4).

See my test config: image image

Clon1998 avatar May 26 '23 23:05 Clon1998

@Clon1998 I have found the root cause, if name of pin is "LED" (upper case), it doesnt work as expected, but if I change naming to "led" (lower case), it works fine

willkaxxx avatar May 27 '23 08:05 willkaxxx

@Clon1998 I have found the root cause, if name of pin is "LED" (upper case), it doesnt work as expected, but if I change naming to "led" (lower case), it works fine

That's interesting and definitely a Bug in mobileraker. I will double check my implementation. Thanks for your reply!

Clon1998 avatar May 27 '23 09:05 Clon1998

I forgot to close this issue. The parsing for most klipper objects was reworked and the keys/config keys are now case-insensitive.

Clon1998 avatar Dec 06 '23 11:12 Clon1998