Change keyEquivalent to show the typed character, not the QWERTY key cap label
Magnet does a great job translating the character of the pressed key into a key code and a "physical" key label. This PR changes property names to avoid confusion:
- Renames the label of a
KeyCombothat corresponds to a QWERTY keyboard key toqwertyKeyLabel - Changed
keyEquivalentto produce a String that corresponds to the actual text character that results from pressing the key, which is needed forNSMenuItemand similar Cocoa/AppKit functionality
For users of Magnet that use KeyCombo for menu item shortcuts (like me), this means that the NSMenuItem.keyEquivalent needs to be updated when the keyboard layout is changed by the user, e.g. from QWERTY to DVORAK. This PR helps by aligning the meaning of "keyEquivalent" for this.
Updated for the latest changes to Sauce etc.
@Econa77 I'm not 100% certain I caught your intention with this PR. And maybe my description is confusing. Would be happy to discuss alternatives!
@Econa77 Just wanted to check if you want to move forward with this
@Econa77 Since you merged another PR recently, maybe you could look into this?