foundationdb-rs
foundationdb-rs copied to clipboard
ci: remove windows
The FDB community is officially discontinuing the Windows build (see apple/foundationdb#5135 for more info). We cannot download msi packages as they were removed from official sites.
As the windows-latest
is mandatory for any PR, this commit is removing
the windows-latest
from Github actions. We may add it back later to
use community build.
Mmmh, I can see some errors related to clap. Clap's MSRV for >=3.0 is 1.54.0, should we bump?
Also, we are targetting structopt = "0.3.3"
which does not exists, latest is 0.3.22.
bindingtester is only "in tree" so we probably don't have to care about MSRV.
Coverage increased (+2.6%) to 70.049% when pulling 23dc27d3f8fb274e8ddbe43e7be1eb35d197d15e on PierreZ:dev/remove-windows into f41fa13eb57aa883944476e29ee81a6708e67b4d on Clikengo:master.
Codecov Report
Merging #233 (23dc27d) into master (f41fa13) will increase coverage by
3.30%
. The diff coverage isn/a
.
:exclamation: Current head 23dc27d differs from pull request most recent head 54c76d2. Consider uploading reports for the commit 54c76d2 to get more accurate results
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
+ Coverage 76.58% 79.88% +3.30%
==========================================
Files 18 18
Lines 3041 3038 -3
==========================================
+ Hits 2329 2427 +98
+ Misses 712 611 -101
Impacted Files | Coverage Δ | |
---|---|---|
foundationdb-gen/src/lib.rs | 0.42% <0.00%> (+<0.01%) |
:arrow_up: |
foundationdb/src/tuple/mod.rs | 89.78% <0.00%> (+0.86%) |
:arrow_up: |
foundationdb-bindingtester/src/main.rs | 90.24% <0.00%> (+1.55%) |
:arrow_up: |
foundationdb/src/tuple/pack.rs | 90.42% <0.00%> (+2.68%) |
:arrow_up: |
foundationdb/src/api.rs | 87.50% <0.00%> (+3.93%) |
:arrow_up: |
foundationdb/src/tuple/element.rs | 63.69% <0.00%> (+4.10%) |
:arrow_up: |
foundationdb/src/future.rs | 90.71% <0.00%> (+4.91%) |
:arrow_up: |
foundationdb/src/database.rs | 72.82% <0.00%> (+6.52%) |
:arrow_up: |
foundationdb/src/transaction.rs | 87.24% <0.00%> (+11.72%) |
:arrow_up: |
foundationdb/src/tuple/versionstamp.rs | 66.66% <0.00%> (+11.90%) |
:arrow_up: |
... and 1 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f41fa13...54c76d2. Read the comment docs.
but CI has (in the current configuration) to run with 1.40...
CI is green on my side, but I had to bump the MSRV to fix it, clang-sys
's transitives dependencies requires 1.46.