dayspan-vuetify
dayspan-vuetify copied to clipboard
When moving a timed event the time is reset to 12am
If, (in month view, possibly in other views without time slots as well), you move a timed event (i.e. not all day) to another day the time is reset to 12am.
Please provide a sample of code (in a CodePen for example) that reproduces the issue. If you can't reproduce the issue outside your environment, there's nothing I can to do help you. After a week or two this issue will be closed out if the issue can't be recreated.
Reproduce by going to the example site, create a timed Event and move it to another day. The time will be reset to 12am. However, I will probably look into this myself this week...
Did some more research, found the culprit. It's CalendarApp::handleMove. Just not sure whether a real error or just wrong expectation. Let me explain..
First scenario: we have a single event with a single time slot. If a user moves this event to another day, as it stands, CalendarApp.vue
will (ultimately) call Schedule.moveSingleEvent
. This method has a parameter takeTime
which will overwrite the times
of the schedule unless set to false
, which it's not. So there is no bug here, which leads to the question; should the user expect that if he moves a timed event that this event will retain its time on the new date?. If so, takeTime
should be set to false when moving a single event in a view which makes it impossible to move an event to a specific time slot. Unfortunately, right now, I don't see an easy solution to make this work since Schedule.moveSingleEvent
is called from Schedule.move
(which is called from CalendarEvent.move
) which does not provide a method of setting takeTime
....
Scenario 2: we have a single event with multiple time slots. As it stands, moving this event to another day will present the user with the option of moving a single instance (the earliest, but choosing a specific one is not possible), but no option to move the entire event. The moved instance will pretty much act like moving a single event and will create a new instance on the target day at 12am.
- Shouldn't the user have the option to move the entire event to another day?
- Shouldn't there be a way for the user to indicate which instance to move?
- Shouldn't the moved instance retain its time slot? (see above)