metabase-clickhouse-driver icon indicating copy to clipboard operation
metabase-clickhouse-driver copied to clipboard

Published 20 hours ago • verified publisher icon ClickHouse

Doesn't pass JDBC version in user agent

Open mshustov opened this issue 1 year ago • 3 comments

Describe the bug

JDBC version is expected to be set in client name. actual result: metabase/1.3.3/unknown (Linux/6.1.0-12-amd64; OpenJDK 64-Bit Server VM/Temurin-11.0.22+7; HttpURLConnection; rv:unknown)

mshustov avatar Jun 17 '24 18:06 mshustov

Would it be a good idea to follow guidelines for the User-Agent header? https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent It means that client will add its version on its own and result would look like metabase/1.3.3 (Linux/6.1.0-12-amd64; OpenJDK 64-Bit Server VM/Temurin-11.0.22+7;) ClickHouseJDBC/0.6.1 (HttpURLConnection; Apache HC 5.2.0)

chernser avatar Jun 19 '24 01:06 chernser

Just in case here is a Java Client issue https://github.com/ClickHouse/clickhouse-java/issues/1698

chernser avatar Jun 19 '24 02:06 chernser

I will leave this open as a reminder to upgrade the JDBC driver when the fix is out.

slvrtrn avatar Jun 19 '24 12:06 slvrtrn

Should be fixed by https://github.com/ClickHouse/metabase-clickhouse-driver/releases/tag/1.53.4

slvrtrn avatar Apr 23 '25 14:04 slvrtrn