clickhouse-kafka-connect icon indicating copy to clipboard operation
clickhouse-kafka-connect copied to clipboard

Update KeeperStateProvider.java

Open Paultagoras opened this issue 10 months ago • 2 comments

This should resolve https://github.com/ClickHouse/clickhouse-kafka-connect/issues/375

Paultagoras avatar Apr 21 '24 19:04 Paultagoras

Nice, however it does need cluster name from the params?

abhishekgahlot2 avatar Apr 22 '24 15:04 abhishekgahlot2

It does, it also raises another question - have you noticed any differences between the tables on each cluster?

Paultagoras avatar Apr 24 '24 16:04 Paultagoras

@Paultagoras I don't see much difference except just some very minor lag of updated values between table in cluster. Not sure if thats going to affect any events

abhishekgahlot2 avatar May 08 '24 13:05 abhishekgahlot2

Screenshot 2024-05-08 at 6 42 01 PM

abhishekgahlot2 avatar May 08 '24 13:05 abhishekgahlot2

Can we add a test for it?

It's exactly-once, which we technically only test in the integration suite (because it uses Keeper)

Paultagoras avatar May 13 '24 16:05 Paultagoras

@Paultagoras i see one of our cloud tests is falling please take a look before

mzitnik avatar May 15 '24 05:05 mzitnik

@Paultagoras i see one of our cloud tests is falling please take a look before

It was failing due to timeout, after warming the instance it reran successfully - that was partly why I changed the timeout in the other PR, but it may need more testing to make sure.

Paultagoras avatar May 15 '24 15:05 Paultagoras