clickhouse-java icon indicating copy to clipboard operation
clickhouse-java copied to clipboard

Update StreamSplitter.java

Open liumaojing opened this issue 2 years ago • 5 comments

The result is truncated.

liumaojing avatar Jun 14 '22 01:06 liumaojing

Benchmark                                (client)  (connection)  (statement)  (type)   Mode  Cnt     Score     Error  Units
Basic.insertOneRandomNumber  clickhouse-http-jdbc         reuse       normal  object  thrpt   20   235.846 ±  32.742  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc         reuse     prepared  object  thrpt   20   237.141 ±  22.870  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc           new       normal  object  thrpt   20   263.457 ±  29.781  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc           new     prepared  object  thrpt   20   239.863 ±  14.777  ops/s
Basic.insertOneRandomNumber  clickhouse-grpc-jdbc         reuse       normal  object  thrpt   20   262.639 ±  41.447  ops/s
Basic.insertOneRandomNumber  clickhouse-grpc-jdbc         reuse     prepared  object  thrpt   20   229.721 ±  24.685  ops/s
Basic.insertOneRandomNumber  clickhouse-grpc-jdbc           new       normal  object  thrpt   20   261.594 ±  40.166  ops/s
Basic.insertOneRandomNumber  clickhouse-grpc-jdbc           new     prepared  object  thrpt   20   220.370 ±  30.317  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc         reuse       normal  object  thrpt   20   989.573 ±  82.668  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc         reuse     prepared  object  thrpt   20  1081.379 ±  95.003  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc           new       normal  object  thrpt   20  1019.543 ± 131.389  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc           new     prepared  object  thrpt   20  1102.916 ±  90.385  ops/s
Basic.selectOneRandomNumber  clickhouse-grpc-jdbc         reuse       normal  object  thrpt   20   897.391 ±  72.810  ops/s
Basic.selectOneRandomNumber  clickhouse-grpc-jdbc         reuse     prepared  object  thrpt   20   907.762 ±  85.577  ops/s
Basic.selectOneRandomNumber  clickhouse-grpc-jdbc           new       normal  object  thrpt   20   900.687 ±  71.798  ops/s
Basic.selectOneRandomNumber  clickhouse-grpc-jdbc           new     prepared  object  thrpt   20   920.357 ±  75.876  ops/s

github-actions[bot] avatar Jun 14 '22 02:06 github-actions[bot]

Thanks @liumaojing. What's the issue you're trying to resolve? Can you add a test? Also looking at the code, I'm not sure when marking will be set to true?

zhicwu avatar Jun 14 '22 03:06 zhicwu

谢谢@liumaojing. 您要解决的问题是什么?可以加个测试吗?也在看代码,我不确定什么时候marking会设置为true?

The column in the query has a long column of data around 65535 bytes, public ByteFragment[] split(byte sep) { StreamSplitter ss = new StreamSplitter(this, sep); debug to this is wrong, shard data error

liumaojing avatar Jun 14 '22 06:06 liumaojing

@liumaojing thanks for contribution as @zhicwu asked can you provide a test for this issue and run locally to verify that all tests are passing and than we could merge

mzitnik avatar Jun 25 '22 19:06 mzitnik

@liumaojing thanks for contribution as @zhicwu asked can you provide a test for this issue and run locally to verify that all tests are passing and than we could merge

This is the real data of our company. I will try to find the scene and reproduce it and provide it to you

liumaojing avatar Jun 29 '22 06:06 liumaojing