clickhouse-java icon indicating copy to clipboard operation
clickhouse-java copied to clipboard
verified publisher icon ClickHouse

fix response close for getRowsUpdated(#1538)

Open wooEnrico opened this issue 1 year ago • 1 comments

Summary

Mono resource manager for updateCount close the response when complete

Checklist

Delete items not relevant to your PR:

  • [ ] Unit and integration tests covering the common scenarios were added
  • [ ] A human-readable description of the changes was provided to include in CHANGELOG
  • [ ] For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

wooEnrico avatar Jan 30 '24 03:01 wooEnrico

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 30 '24 03:01 CLAassistant

@wooEnrico would you please resubmit your PR? I have accidently merge it but it broke com.clickhouse.r2dbc.spi.test.R2DBCTestKitImplTest.segmentSelectWithEmitsRow what is part of 3rd-party test library.

Please also put more description about why this change is needed and what is the problem with current code.

Thanks!

chernser avatar May 30 '24 19:05 chernser

I have improved the submission and passed the unit test. And I hope you can review #1667 again

wooEnrico avatar Jun 03 '24 08:06 wooEnrico