clickhouse-java icon indicating copy to clipboard operation
clickhouse-java copied to clipboard

Published 20 hours ago • verified publisher icon ClickHouse

Drop gRPC client

Open zhicwu opened this issue 1 year ago • 4 comments

Summary

Closes #1399

Checklist

Delete items not relevant to your PR:

  • [ ] Unit and integration tests covering the common scenarios were added
  • [x] A human-readable description of the changes was provided to include in CHANGELOG
  • [ ] For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

zhicwu avatar Jul 16 '23 13:07 zhicwu

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jul 16 '23 14:07 sonarqubecloud[bot]

Hi @mzitnik, please review this pull request at your earliest convenience. I will be submitting a few more pull requests for updating dependencies, addressing bugs, and merging pending pull requests.

zhicwu avatar Jul 16 '23 14:07 zhicwu

@zhicwu did you decide to drop gRPC ?

mzitnik avatar Jul 19 '23 08:07 mzitnik

Yes, I see no benefit of keeping this but troubles(e.g. never production ready, CI failure time from time, and extra dependencies etc.). As I mentioned in the linked issue, Apache Arrow Flight is probably a better choice, and hopefully it will be supported in the future.

zhicwu avatar Jul 19 '23 14:07 zhicwu