clickhouse-cpp icon indicating copy to clipboard operation
clickhouse-cpp copied to clipboard

memory copy ---- void ColumnString::Append(ColumnRef column)

Open 1261385937 opened this issue 3 years ago • 1 comments

The void ColumnString::Append(ColumnRef column) also has memory copy
BTW , In my scenario, the given column data (huge) will be no useful after calling this interface.
Here is a complicated inherit. If i make a overload interface, will be a lot of modification.

@Enmk , any suggest ?
I will submit a PR this weekend.

1261385937 avatar Aug 11 '22 02:08 1261385937

Addressed in https://github.com/ClickHouse/clickhouse-cpp/pull/212

Enmk avatar Oct 04 '22 13:10 Enmk