ClickHouse icon indicating copy to clipboard operation
ClickHouse copied to clipboard

Add majority_insert_quorum setting

Open SachinSetiya opened this issue 2 years ago • 3 comments

majority_insert_quorum is defined as (number_of_replicas/2)+1. Insert will be successful only if majority of quorum have applied it. If insert_quorum and majority_insert_quorum both are specified, max of both will be used.

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add support for majority_insert_quorum

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

SachinSetiya avatar Aug 08 '22 05:08 SachinSetiya

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 08 '22 05:08 CLAassistant

I have not added integration_tests, because I am still not able to run integration tests on my system

SachinSetiya avatar Aug 08 '22 05:08 SachinSetiya

Related to #38700

tavplubix avatar Aug 08 '22 11:08 tavplubix

@SachinSetiya Do you mind if I'll continue this PR? Or if there're some updates from you, we can wait.

vdimir avatar Aug 23 '22 10:08 vdimir

Hi Vladimir,

Sorry I got quite busy , so I won't be able to continue the PR, you can continue with it.

Thanks

On Tue, Aug 23, 2022, 11:10 Vladimir C @.***> wrote:

@SachinSetiya https://github.com/SachinSetiya Do you mind if I'll continue this PR? Or if there're some updates from you, we can wait.

— Reply to this email directly, view it on GitHub https://github.com/ClickHouse/ClickHouse/pull/39970#issuecomment-1223854934, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWHMMBPFIPMI4Y75KY3KS3V2SPQLANCNFSM5532M6JA . You are receiving this because you were mentioned.Message ID: @.***>

SachinSetiya avatar Aug 23 '22 10:08 SachinSetiya

https://s3.amazonaws.com/clickhouse-test-reports/39970/f008b07049399eb440ef663462f85aa2b896cf92/stateless_tests__release__databasereplicated__[2/2].html

02377_majority_insert_quorum_zookeeper_long

2022-08-25 13:43:33 The query succeeded but the server error '319' was expected (query: INSERT INTO quorum1 VALUES (2, '2018-11-15'); -- { serverError 319 }).
2022-08-25 13:43:33 Received exception from server (version 22.9.1):
2022-08-25 13:43:33 Code: 289. DB::Exception: Received from localhost:9000. DB::Exception: Replica doesn't have part 20181115_1_1_0 which was successfully written to quorum of other replicas. Send query to another replica or disable 'select_sequential_consistency' setting.. (REPLICA_IS_NOT_IN_QUORUM)
2022-08-25 13:43:33 (query: SELECT x FROM quorum2 ORDER BY x;)

I'm going to investigate...

vdimir avatar Aug 30 '22 11:08 vdimir