TurbulenceConvection.jl
TurbulenceConvection.jl copied to clipboard
Updraft top and updraft height are not interchangeable, but this is implied in our implementation
The pressure and entrainment closures make use of updraft_top
in their implementation, measured from z=0
. However, at least for the pressure closure, the ansatz written in the papers contained the updraft height instead (i.e, top - base of the updraft).
A consistent implementation of updraft_height in a code where the updraft fraction may arbitrarily become zero and non-zero at any height would be:
updraft_height[k] = current_updraft_top(k) - current_updraft_base(k)
where
current_updraft_top(k) = z[first element i above k such that updraft_fraction[i+1] = 0]
current_updraft_base(k) = z[first element j below k such that updraft_fraction[j-1] = 0]
Both should be equivalent for most of our cases, but not for cases where updrafts disappear/reappear or detach from the wall (e.g., bubble). This is low priority overall, but inconsistent for some of our cases.