SurfaceFluxes.jl icon indicating copy to clipboard operation
SurfaceFluxes.jl copied to clipboard

There are two distinct `universal_func_type`s

Open glwagner opened this issue 1 year ago • 0 comments

There are two functions called universal_func_type. One is defined in UniversalFunctions:

https://github.com/CliMA/SurfaceFluxes.jl/blob/f83dc8642b032184c3b31b2c444ed1a6f43168f1/src/UniversalFunctions.jl#L1113

and the other is defined in Parameters:

https://github.com/CliMA/SurfaceFluxes.jl/blob/f83dc8642b032184c3b31b2c444ed1a6f43168f1/src/Parameters.jl#L25

The prefix UF in the second is what allows this duplication.

The Parameters version is called here:

https://github.com/CliMA/SurfaceFluxes.jl/blob/f83dc8642b032184c3b31b2c444ed1a6f43168f1/src/SurfaceFluxes.jl#L293

This is annoying if one needs to extend universal_func_type in an external package, so I propose we eliminate the dichotomy and use just one function.

glwagner avatar Jan 10 '24 02:01 glwagner