RRTMGP.jl
RRTMGP.jl copied to clipboard
Remove magic indexes
Magic indexes are used for the dry component of gas_col
(0 when using OffsetArrays
, 1 with an offset for ordinary Arrays
), which complicates the logic. This may be linked to #183, depending on the order things are fixed.
This was not fixed by #185
@charleskawczynski , @dennisYatunin , I believe this issue is no longer relevant. I would like to close this unless there are additional comments!
Magic indices are still used, I wouldn't call this closed.
We no longer use offset arrays. All indices start from 1.
That's not the point, the point is that these indices refer to specific gases, and we have to keep track of where they are throughout the code.
This is done through a dictionary.