ParameterEstimocean.jl icon indicating copy to clipboard operation
ParameterEstimocean.jl copied to clipboard

Proper `BatchedObservations` with optional weights?

Open glwagner opened this issue 3 years ago • 3 comments

Sometimes we'd like to emphasize some SyntheticObservations over others. We can express this by introducing an object BatchedObservations rather than using a simple Vector:

struct BatchedObservations
    batch
    weights
end

By default the weights are all 1, but this could be overridden to emphasize / demphasize certain members of the batch.

glwagner avatar Feb 03 '22 00:02 glwagner

Then in the scripts "observations" could refer to a single instance of SyntheticObservations, a vector of SyntheticObservations or an instance of BatchedObservations. Do you think this would create confusion?

adelinehillier avatar Feb 03 '22 02:02 adelinehillier

I think if we decide to implement BatchedObservations we'll probably want to discontinue support for Vector{<:SyntheticObservations} just for clarity's sake.

glwagner avatar Feb 03 '22 02:02 glwagner

Well, we can actually just auto-convert Vector{<:SyntheticObservations} to batched observations. So these changes need happen only under the hood.

This feature is really specific to column models through, for which a single ensemble simulation can handle many observations. I think for basically every other problem we'll need BatchedInverseProblem.

glwagner avatar Apr 08 '22 15:04 glwagner