Oceananigans.jl icon indicating copy to clipboard operation
Oceananigans.jl copied to clipboard

C⭕️l⭕️rs in `show()` methods

Open navidcy opened this issue 3 years ago • 8 comments

A great idea by @glwagner.

Why not?!

navidcy avatar Feb 28 '22 00:02 navidcy

Yes, great idea!

francispoulin avatar Feb 28 '22 13:02 francispoulin

https://github.com/FedeClaudi/Term.jl is useful for that ;)

navidcy avatar Mar 23 '22 08:03 navidcy

Maybe we can use Term.jl to implement a default / convenience log utility for simulations

glwagner avatar Mar 23 '22 12:03 glwagner

@christophernhill maybe a state checker utility could use Term.jl?

glwagner avatar Mar 23 '22 12:03 glwagner

Something was marked as a good first issue. Can I tackle this?

iuryt avatar Mar 24 '22 08:03 iuryt

Go for it! If you want to discuss an idea before writing code, let's discuss here. Here's my thoughts:

  1. We can add a color to an important show method like one / all of the models, or Simulation
  2. We can add a nice utility for logging progress that uses Term.jl, that users can configure and then add to simulation.callbacks (we could also consider making it default)

glwagner avatar Mar 24 '22 14:03 glwagner

Ok

So, to do that, I will fork the main repo and do my modifications. How can I test the forked repo while running julia?

iuryt avatar Mar 25 '22 15:03 iuryt

Started a discussion for that: https://github.com/CliMA/Oceananigans.jl/discussions/2384

glwagner avatar Mar 25 '22 16:03 glwagner