ClimateMachine.jl icon indicating copy to clipboard operation
ClimateMachine.jl copied to clipboard

Add Kennedy Gruber split form to Atmos

Open mwarusz opened this issue 3 years ago • 5 comments

This PR aims to bring some of the functionality added in https://github.com/CliMA/ClimateMachine.jl/pull/2188 to the Atmos model. It adds Kennedy Gruber split form of the Atmos model equations using the tendency specification framework.

CC:

@sandreza @charleskawczynski

  • [ ] Code follows the style guidelines OR N/A.
  • [ ] Unit tests are included OR N/A.
  • [ ] Code is exercised in an integration test OR N/A.
  • [ ] Documentation has been added/updated OR N/A.

mwarusz avatar May 03 '21 18:05 mwarusz

bors try

mwarusz avatar May 10 '21 22:05 mwarusz

try

Build failed:

bors[bot] avatar May 10 '21 23:05 bors[bot]

I wonder, why you guys choose the Kennedy and Gruber split form?

In my opinion, the Shima_et_al split form is preferable, as it keeps pressure equilibrium preserved and the total energy is consistent to the inner energy and the kinetic energy, but I am curious if there is a particular reason for KG splitting?

gregorgassner avatar Jul 22 '21 07:07 gregorgassner

This PR was meant as a proof of concept for adding split forms to the model. There was no particular reason for implementing KG first, other that its simplicity and that it seemed to be enough for stability.

mwarusz avatar Jul 22 '21 17:07 mwarusz

Thanks for the answer. Makes a lot of sense! Cheers.

gregorgassner avatar Jul 22 '21 18:07 gregorgassner