ClimateMachine.jl icon indicating copy to clipboard operation
ClimateMachine.jl copied to clipboard

Add vars wrappers for numerical fluxes

Open charleskawczynski opened this issue 4 years ago • 25 comments

Description

This PR:

  • Add vars wrappers for numerical fluxes
  • Adds a WrapVars type, to indicate when balance law kernels are wrapped in Vars
  • [ ] Code follows the style guidelines OR N/A.
  • [ ] Unit tests are included OR N/A.
  • [ ] Code is exercised in an integration test OR N/A.
  • [ ] Documentation has been added/updated OR N/A.

charleskawczynski avatar Feb 13 '21 19:02 charleskawczynski

bors try

charleskawczynski avatar Feb 13 '21 19:02 charleskawczynski

try

Build failed:

bors[bot] avatar Feb 13 '21 20:02 bors[bot]

bors try

charleskawczynski avatar Feb 14 '21 00:02 charleskawczynski

try

Build failed:

bors[bot] avatar Feb 14 '21 01:02 bors[bot]

bors try

charleskawczynski avatar Mar 23 '21 16:03 charleskawczynski

try

Build failed:

bors[bot] avatar Mar 23 '21 17:03 bors[bot]

bors try

charleskawczynski avatar Mar 23 '21 19:03 charleskawczynski

try

Build failed:

bors[bot] avatar Mar 23 '21 19:03 bors[bot]

bors try

charleskawczynski avatar Mar 24 '21 15:03 charleskawczynski

try

Build failed:

bors[bot] avatar Mar 24 '21 16:03 bors[bot]

bors try

charleskawczynski avatar Mar 24 '21 16:03 charleskawczynski

bors try

charleskawczynski avatar Mar 24 '21 17:03 charleskawczynski

try

Already running a review

bors[bot] avatar Mar 24 '21 17:03 bors[bot]

try

Build failed:

bors[bot] avatar Mar 24 '21 17:03 bors[bot]

bors try

charleskawczynski avatar Mar 24 '21 22:03 charleskawczynski

try

Build failed:

bors[bot] avatar Mar 24 '21 22:03 bors[bot]

bors try

charleskawczynski avatar Mar 24 '21 23:03 charleskawczynski

try

Build failed:

bors[bot] avatar Mar 25 '21 00:03 bors[bot]

bors try

charleskawczynski avatar Mar 25 '21 00:03 charleskawczynski

try

Build failed:

bors[bot] avatar Mar 25 '21 01:03 bors[bot]

bors try

charleskawczynski avatar Mar 25 '21 15:03 charleskawczynski

Looks like this is finally ready. It adds a bit of code, but it simplifies the kernels a bit. Would it be better to change _loop! to _loop_bcs!?

charleskawczynski avatar Mar 25 '21 17:03 charleskawczynski

Bump! cc @simonbyrne @jkozdon. This may make grepping a bit easier. I'm now regretting the _arr! suffix a bit.

charleskawczynski avatar Mar 31 '21 17:03 charleskawczynski

@charleskawczynski can you close this? Seems pretty stale.

jkozdon avatar Mar 01 '23 18:03 jkozdon