ClimaLand.jl icon indicating copy to clipboard operation
ClimaLand.jl copied to clipboard

Implicit solver enhancements

Open juliasloan25 opened this issue 4 months ago • 1 comments

Purpose

In milestone O2.3.6, we have implemented implicit solvers for RichardsModel, EnergyHydrologyModel, and SoilCanopyModel. As we developed these, we identified some areas for improvement that we want to address at some point, as well as ideas for improved stability that may or may not be necessary. These are documented here.

Cost/benefits/risks

costs: developer time benefits: increased simulation stability, decreased code duplication, more robust code risks: potential regressions if we alter equations

Producers

@juliasloan25 @kmdeck

Components

  • more accurate jacobian approximations for increased simulation stability
  • code cleanup

Inputs

Implicit solvers introduced in #135

Results and deliverables

Maintain or improve stability of implicitly-stepped experiments

Reviewers

@juliasloan25 @kmdeck @dennisYatunin (PRs) @tapios @cmbengue (SDI review)

Tasks

### general implicit stepping
- [ ] #659
- [ ] #661
### SoilCanopyModel
- [ ] #782
### EnergyHydrologyModel
- [ ] #662
- [ ] include boundary condition contributions (if needed)
- [ ] include contribution from drhoe_int / dtheta_l (if needed)
- [ ] understand how to treat soil phase change implicitly
### RichardsModel
- [ ] smooth derivative dPsi/dtheta at theta = \nu (if needed)

juliasloan25 avatar Oct 02 '24 20:10 juliasloan25