CalibrateEDMF.jl icon indicating copy to clipboard operation
CalibrateEDMF.jl copied to clipboard

refactor: remove unused grid search code

Open haakon-e opened this issue 3 years ago • 4 comments

Changes

This PR removes get_parameter_pairs from the grid_search code, which would take the input parameters and expand them with its default vector components if they are vector parameters. This is in fact already done in the expand_params function in CEDMF > HelperFuncs.jl.

The rationale for this change is that with the existing code, ParameterMap would not function correctly on vector components for the case where one would like to run grid search over one component and fix the other component to some fixed value, since the code would erroneously think all vector components were being calibrated.

Issue number (if applicable)

Checklist before requesting a review / merging

  • [x] I have formatted the code using julia --project=.dev .dev/climaformat.jl .
  • [x] I have updated all test manifests using julia --project .dev/up_deps.jl . with Julia 1.7.3.
  • [x] If core features are added, I have added appropriate test coverage.
  • [x] If new functions and structs are added, they are documented through docstrings.

haakon-e avatar Aug 02 '22 19:08 haakon-e

bors r+

haakon-e avatar Aug 02 '22 21:08 haakon-e

Build failed:

bors[bot] avatar Aug 02 '22 21:08 bors[bot]

bors r+

haakon-e avatar Aug 02 '22 21:08 haakon-e

Build failed:

bors[bot] avatar Aug 02 '22 22:08 bors[bot]