clevertap-react-native icon indicating copy to clipboard operation
clevertap-react-native copied to clipboard

fix: Update React-Core pod + react-native peerDependency

Open philly25 opened this issue 4 years ago • 2 comments

According to this https://github.com/facebook/react-native/issues/29633#issuecomment-694187116 dependencies should be updated. Perhaps issue came out when using use_frameworks! in pod file (as in our project).

It's time to move on and bump dependencies.

philly25 avatar Sep 20 '21 19:09 philly25

Here is an error message I'm getting (which is being fixed by this PR):

Undefined symbols for architecture arm64:
  "_OBJC_CLASS_$_RCTEventEmitter", referenced from:
      _OBJC_CLASS_$_CleverTapReactEventEmitter in CleverTapReactEventEmitter.o
  "_OBJC_METACLASS_$_RCTEventEmitter", referenced from:
      _OBJC_METACLASS_$_CleverTapReactEventEmitter in CleverTapReactEventEmitter.o
  "__RCTLogNativeInternal", referenced from:
      -[CleverTapReact getInitialUrl:] in CleverTapReact.o
      -[CleverTapReact registerForPush] in CleverTapReact.o
      -[CleverTapReact setPushTokenAsString:withType:] in CleverTapReact.o
      -[CleverTapReact enablePersonalization] in CleverTapReact.o
      -[CleverTapReact disablePersonalization] in CleverTapReact.o
      -[CleverTapReact setOffline:] in CleverTapReact.o
      -[CleverTapReact setOptOut:] in CleverTapReact.o
      ...
  "_RCTRegisterModule", referenced from:
      +[CleverTapReact load] in CleverTapReact.o
      +[CleverTapReactEventEmitter load] in CleverTapReactEventEmitter.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

@akashvercetti @Aditi3 Could you please take a look?

philly25 avatar Jan 21 '22 13:01 philly25

@philly25 We are in the final stages of updating our native iOS SDK. The immediate next step would be to update the react-native SDK linked to the latest iOS SDK. We will add your fix to this update as well as soon as possible.

akashvercetti avatar Jan 24 '22 05:01 akashvercetti

@akashvercetti Do we plan to merge this in the next PE RN release?

darshanclevertap avatar May 22 '23 06:05 darshanclevertap

@akashvercetti Do we plan to merge this in the next PE RN release?

These changes have been implemented in previous releases. Closing this PR.

akashvercetti avatar May 22 '23 09:05 akashvercetti