Add invisible FragmentHostActivity to support custom HTML in-app messages on NativeActivity
This PR adds support for rendering CleverTap’s fragment-based in-app notifications (e.g. custom HTML) in Unreal Engine projects that use a NativeActivity, which does not support fragments.
Problem
CleverTap’s SDK assumes that the current activity is a FragmentActivity, but Unreal-based Android apps typically use NativeActivity. As a result, certain in-app notification types (notably HTML-based ones) fail to display or cause runtime exceptions.
Solution
Introduced a minimal FragmentHostActivity that subclasses AppCompatActivity and provides a safe fragment container.
Added logic to detect when the current activity is not a FragmentActivity, defer the notification, and launch FragmentHostActivity instead.
Once launched, the host activity proceeds with CleverTap’s regular rendering logic.
This approach isolates fragment-specific logic to a dedicated host, without modifying the behavior for apps already using FragmentActivity.
Summary by CodeRabbit
-
New Features
- Introduced a new activity to host in-app notifications that require a fragment environment, ensuring smoother display for specific notification types.
- Added a custom theme for the new activity, providing a transparent, fullscreen, and title-less appearance for hosted notifications.
-
Bug Fixes
- Improved handling of in-app notifications by deferring their display until a suitable environment is available, preventing display issues.
Walkthrough
A new activity, FragmentHostActivity, was introduced to host specific in-app notification types requiring a fragment environment without transition animations. The AndroidManifest and styles were updated to support this activity, and logic was added to InAppController to launch the host activity when needed, deferring notification display until the environment is suitable.
Changes
| File(s) | Change Summary |
|---|---|
clevertap-core/src/main/AndroidManifest.xml |
Added FragmentHostActivity declaration with custom theme, no history, singleTop launch mode, and not exported. |
clevertap-core/src/main/java/com/clevertap/android/sdk/FragmentHostActivity.java |
Introduced FragmentHostActivity class to host fragments without transition animations; includes static launch and hosting state methods, lifecycle overrides, and fragment lifecycle callbacks. |
clevertap-core/src/main/java/com/clevertap/android/sdk/inapp/InAppController.java |
Updated showInApp to check notification type; launches FragmentHostActivity if needed and re-queues notifications. Added helper method for type checking. |
clevertap-core/src/main/res/values/styles.xml |
Added CleverTapFragmentHostTheme style for transparent, fullscreen, no-title, and translucent window configuration. |
Sequence Diagram(s)
sequenceDiagram
participant AppActivity as App Activity
participant InAppController
participant FragmentHostActivity
AppActivity->>InAppController: showInApp(notification)
InAppController->>InAppController: requiresFragmentHost(type)?
alt Requires Fragment Host & Not in FragmentActivity
InAppController->>InAppController: Re-queue notification
InAppController->>FragmentHostActivity: launch(current)
Note right of FragmentHostActivity: Activity starts with no animation
FragmentHostActivity->>FragmentHostActivity: onCreate/onResume (set hosting)
FragmentHostActivity->>FragmentHostActivity: Register fragment lifecycle callbacks
else
InAppController->>AppActivity: Display notification
end
[!NOTE]
⚡️ AI Code Reviews for VS Code, Cursor, Windsurf
CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Learn more here.
📜 Recent review details
Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between c0c1e840e6de294dcb74f083414c9f1d2a8d9091 and 0f0ca5bfc9a4c4c30c60df1001ac9ee8818cc3ef.
📒 Files selected for processing (1)
clevertap-core/src/main/java/com/clevertap/android/sdk/FragmentHostActivity.java(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- clevertap-core/src/main/java/com/clevertap/android/sdk/FragmentHostActivity.java
✨ Finishing Touches
- [ ] 📝 Generate Docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Explain this complex logic.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai explain this code block.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and explain its main purpose.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai generate docstringsto generate docstrings for this PR.@coderabbitai generate sequence diagramto generate a sequence diagram of the changes in this PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
it’s only activated when the current activity doesn’t support fragments. I don’t know why you’d want to fail to display some types of inapp notifications when fragments aren’t supported in the current activity.
When the current activity does support fragments (which is the recommended setup), this patch should have no effect.
That said, the UX of this patch isn’t great, as the underlying NativeActivity can’t be interacted with while the fragment host is active.
I'm hoping the Android team can find a better solution!
From: CTLalit @.> Sent: Tuesday, May 27, 2025 5:17:02 PM To: CleverTap/clevertap-android-sdk @.> Cc: Simon Bullen @.>; Mention @.> Subject: Re: [CleverTap/clevertap-android-sdk] Add invisible FragmentHostActivity to support custom HTML in-app messages on NativeActivity (PR #809)
@CTLalit requested changes on this pull request.
@simonbullenhttps://github.com/simonbullen I think this is apply changes to all SDK flows. Consider putting behind a flag which can be provided to core-sdk from Unity (any other third party) and make it configurable?
— Reply to this email directly, view it on GitHubhttps://github.com/CleverTap/clevertap-android-sdk/pull/809#pullrequestreview-2869895873, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWMZFBJ6FS6Q63P67CQNSML3AQGO5AVCNFSM6AAAAAB5XUMKGWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQNRZHA4TKOBXGM. You are receiving this because you were mentioned.Message ID: @.***>
@simonbullen makes sense, i saw the code of this patch working only when underlying infra does not support fragments (via instanceOf check). We have added this in our docs to use a specific type of activity; but thanks for providing this piece, we will consider getting it checked in after discussion with my team.