Cataclysm-DDA icon indicating copy to clipboard operation
Cataclysm-DDA copied to clipboard

mil_surplus itemgroup isn't used in mil_surplus location

Open dynst opened this issue 7 months ago • 2 comments

Is your feature request related to a problem? Please describe.

https://github.com/CleverRaven/Cataclysm-DDA/blob/fc91646d6195953567b0c70574055044db279cb0/data/json/itemgroups/Locations_MapExtras/locations_commercial.json#L642

The mil_surplus itemgroup isn't used in the one place you'd expect, it's mostly just in the second floor of the mall and storage units.

Solution you would like.

Figure out the right amount to add to mapgen/mil_surplus.json

Describe alternatives you have considered.

Just delete the oversized itemgroup?

Additional context

#36825

The military surplus store was originally written in C++. #24274

The mil_surplus itemgroup was, too, it's old as rocks.

https://github.com/CleverRaven/Cataclysm-DDA/blob/1ca7f2a6c8e68ffbcbe4d945fe95ebb2e90c8e30/data/raw/item_groups.json#L1637

dynst avatar May 31 '25 20:05 dynst

i would say it's a good candidate to be deleted, as we have more groups now that represent surplus stuff better than mashup of random garbage

GuardianDll avatar May 31 '25 20:05 GuardianDll

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

github-actions[bot] avatar Jun 15 '25 21:06 github-actions[bot]