Cataclysm-DDA icon indicating copy to clipboard operation
Cataclysm-DDA copied to clipboard

Increment decrement operators single string

Open Procyonae opened this issue 1 year ago • 2 comments

Summary

None

Purpose of change

Apply https://github.com/CleverRaven/Cataclysm-DDA/pull/77238 to the repo. This PR is just ++ and --

Describe the solution

Replace ",[ \n\r]+"++" with ++" and ",[ \n\r]+"--" with --"

Describe alternatives you've considered

Testing

Manually reviewed changes

Additional context

Procyonae avatar Nov 29 '24 11:11 Procyonae

Why not \s for 'any whitespace'? Does that catch more cases?

akrieger avatar Nov 29 '24 18:11 akrieger

I just forgot that was a thing, my retention of regex stuff is abysmal '^^

Procyonae avatar Nov 29 '24 18:11 Procyonae

Ok so this is not ready for merge?

Maleclypse avatar Dec 05 '24 05:12 Maleclypse

quick search yield no additional hits (if my regex is up to par)

results

Screenshot from 2024-12-06 14-19-51 Screenshot from 2024-12-06 14-20-56 Screenshot from 2024-12-06 14-21-32 Screenshot from 2024-12-06 14-22-16

marilynias avatar Dec 06 '24 13:12 marilynias

Ye this is good to go I think \s is equivalent to [ \t\n\r] and we don't allow tabs so what I did is just slightly uglier but does the same thing

Procyonae avatar Dec 06 '24 13:12 Procyonae