`Request review` always* fails

[Brambor]

Describe the bug

Request review either concludes that nobody is to be pinged and then successfully ends. Or it finds somebody to ping and then fails instead of requesting the review.

from:

• #76433

Attach save file

N/A

Steps to reproduce

I am not sure. Make a PR with changes to a file somebody is subscribed to? Make it Qrox to be sure it fails.

Expected behavior

I would either disable the test or fix it. Currently, it gives no value. It never requests a review which is the whole point.

Screenshots

No response

Versions and configuration

N/A

Additional context

Search "request review" on Discord for more insight.

[Brambor]

• Requesting @ KorGgenT in #76617 didn't fail.

[RenechCDDA]

• Requesting @ KorGgenT in Refactor: Remove unnecessary parameter avatar and map #76617 didn't fail.

Because Korggent has push permissions and it never triggered iscollaborator(), I'm pretty sure.

https://github.com/Qrox/auto-request-review/blob/481e6cd2f5d57b6e914d81ca731211384a76798f/src/github.js#L114-L118

My best guess is that either the octokit module is no longer supported (doesn't seem to be the case) or there has been some unknown permissions requirement increase. Taking a look at the actions log it looks like the failures started on June 8th... I was kind of hoping to use the logged failures to figure out what happened but uh, this PR couldn't have caused it. Checked github's blog, nothing terribly suspicious around that date.

[RenechCDDA]

@Qrox Any chance you could lend us your wisdom?

Harakka seemed to think it was an API change and also identified that function so that's what I'm going with 🤷

[Qrox]

If it is failing inside is_collaborator and throwing an error, then my best guess is that the returned error status when a user is not a collaborator is somehow not 404, which will trigger this line. When the user is a collaborator, the returned status is 204 so it succeeds. I haven't tested though.

[Procyonae]

https://github.com/Qrox/auto-request-review/pull/1 should hopefully fix it (we'll need to update https://github.com/CleverRaven/Cataclysm-DDA/blob/master/.github/workflows/request-review.yml#L23 to the new commit)