Cataclysm-DDA icon indicating copy to clipboard operation
Cataclysm-DDA copied to clipboard

fix compilation error calling Character::spawn_items

Open db48x opened this issue 1 year ago • 5 comments

Summary

Bugfixes "fix compilation error calling Character::spawn_items"

Purpose of change

Fix compilation error calling Character::spawn_items

Describe the solution

Call pos_bub() instead of pos()

Additional context

Seems to have been caused by pushing #75125 after #76266 without building first.

db48x avatar Sep 11 '24 07:09 db48x

Looks like #76297 added to the pileup

RenechCDDA avatar Sep 11 '24 09:09 RenechCDDA

Yup. I’ll leave that one to an expert though.

db48x avatar Sep 11 '24 09:09 db48x

Yup. I’ll leave that one to an expert though.

A PR won't be able to pass basic build and get merged without both of these errors resolved, unfortunately. Can I interest you in applying this patch to this PR?

index 8924c98c47..f09dd8640b 100644
--- a/data/mods/My_Sweet_Cataclysm/sweet_monsters.json
+++ b/data/mods/My_Sweet_Cataclysm/sweet_monsters.json
@@ -485,7 +485,7 @@
     "harvest": "caff_gum_spider",
     "anger_triggers": [ "STALK", "PLAYER_WEAK", "HURT", "PLAYER_CLOSE" ],
     "flags": [ "SEES", "SMELLS", "HEARS", "CLIMBS", "PATH_AVOID_FIRE", "PATH_AVOID_FALL" ],
-    "reproduction": { "baby_egg": "caff_gum", "baby_count": 10, "baby_timer": 5 },
+    "reproduction": { "baby_type": { "baby_egg": "caff_gum" }, "baby_count": 10, "baby_timer": 5 },
     "armor": { "bash": 4, "cut": 8, "bullet": 6 }
   },
   {

RenechCDDA avatar Sep 11 '24 10:09 RenechCDDA

we have #76358 now i'm not sure is it possible to merge this and 76358 as two separate PRs tho

GuardianDll avatar Sep 11 '24 13:09 GuardianDll

It's not possible, because both PRs separately will fail a required test. Not even Kevin can ignore that (besides removing the requirement on the build), so both issues have to be fixed in a single PR.

mqrause avatar Sep 11 '24 13:09 mqrause

I’m glad you guys fixed that without waiting for me to wake up :)

db48x avatar Sep 11 '24 20:09 db48x