Cataclysm-DDA icon indicating copy to clipboard operation
Cataclysm-DDA copied to clipboard

uilist now draws selected row without color

Open db48x opened this issue 1 year ago • 1 comments

Summary

Interface "improve contrast in uilist menus by not allowing colored text in highlighted menu items"

Purpose of change

Fixes #75974

Describe the solution

Just remove color tags from the string (caching the results so it only has to be done once per menu item) and then choose between colored or uncolored text as appropriate.

Describe alternatives you've considered

Just not.

Testing

Start at the main menu and load a game. The menu to choose a character uses color in the menu item text, so you can see right away how it works. Most other menus don’t use color like this.

db48x avatar Sep 11 '24 04:09 db48x

Build errors fixed in #76349

db48x avatar Sep 11 '24 07:09 db48x

I fixed the merge conflict; now let’s wait and see if the spurious test failure went away as well.

db48x avatar Sep 19 '24 08:09 db48x