Cataclysm-DDA icon indicating copy to clipboard operation
Cataclysm-DDA copied to clipboard

Character becomes underweight and unhealthy after converting save from 0.G to 0.H

Open phelieros opened this issue 1 year ago • 5 comments

Describe the bug

After loading 0.G save in current release candidate, character that has normal weight and health becomes both underweight and unhealthy after first loading into the game in 0.H.

Here's a stat comparison screenshot, upper one is 0.G and lower one is 0.H: stat comparison

That immediately results in rather crippling penalties of -21 to speed and penalty to several stats from being underweight, and character being unhealthier in the long run.

Attach save file

0.G save 0.G save.zip

0.H save, after loading the above one and saving the game. Hosston-trimmed.tar.gz

Steps to reproduce

Two options:

  1. If you have both versions installed:
  • Load a 0.G save and check character stats.
  • Load this save in 0.H and compare the difference.
  1. If you have only 0.H installed: Load the save and compare stats to those in the upper part of attached screenshot above.

Expected behavior

Character stats upon loading the save in 0.H are identical to those in 0.G

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19045.3570 (22H2)
  • Game Version: c6ba9a2 [64-bit]
  • Graphics Version: Tiles
  • Game Language: English <color_dark_gray>(100.0%) [en]
  • Mods loaded: [ Dark Days Ahead [dda], Portal Storms Ignore NPCs [personal_portal_storms] ]

Additional context

No response

phelieros avatar Sep 11 '24 04:09 phelieros

It might not be worthwhile building a tool to convert the save from 0.G to 0.H.

If the stats in 0.H are that way, there is probably a real cause in the game that is making you 'feel bad' or 'underweight', and that is accounted for in 0.G. Imagine a survivor eating nothing but meat and missing out on some vitamins and minerals, but the game didn't care about that in 0.G. Now in 0.H, we have systems to account for those, and so, your survivor is getting scurvy.

If it is impossible to fix these stats to bring them to normal or healthy, then that is a bug.

CoroNaut avatar Sep 11 '24 05:09 CoroNaut

We're not in the process of building any tools, this would be part of the game code. This is most likely due to a change in BMI calculation that accounts for fat and muscle mass, which 0.G didn't do. Not sure if we can detect this on load and convert to similar proportional BMI as the character had in 0.G.

harakka avatar Sep 11 '24 06:09 harakka

detect this on load and convert to similar proportional BMI as the character had in 0.G.

This seems like a reasonable solution. Having both weight and health apply respective penalties after loading into new version is pretty confusing as there's no indication in the UI as to why this is happening.

phelieros avatar Sep 11 '24 06:09 phelieros

Actually we may not be able to detect this happening, but should at minimum add a comment about it in release notes if it reproduces

What you as a player can do is to reset your nutrition from debug menu.

harakka avatar Sep 11 '24 11:09 harakka

Actually we may not be able to detect this happening, but should at minimum add a comment about it in release notes if it reproduces

What you as a player can do is to reset your nutrition from debug menu.

I've tried resetting basic needs in debug and it worked, penalties are gone.

May this be another possible solution to this problem then ? Just resetting player char's basic needs upon first loading into 0.H.

phelieros avatar Sep 11 '24 12:09 phelieros