Yrax protocols part1

[Vgoloshivskiy]

Summary

Content "Slightly Expands Hub-01 and Yrax factions"

Purpose of change

Yrax don't have a whole lot of content associated with them. I added a bit, plan on adding more content

Describe the solution

It adds to Yrax something more than just optional fight

Describe alternatives you've considered

I have no motivation to rewrite entire conversation "("

Testing

Worked without crashes but Hub reacted to robots only if i was holding them in inventory idk is it fixable or not

Additional context

Next part i will try myself at map editing and creating Gold Pyramid that reacts to electricity (being shot by laser / chain lightning from zed or emp grenade) or maybe being connected to generator

[John-Candlebury]

I'm not particularily sold on the player being able to disable the rest of the drones beyond the trifacet. The trifacet is only deactivable because the US government managed to recover and study at least one before the world eneded.

[Vgoloshivskiy]

I'm not particularily sold on the player being able to disable the rest of the drones beyond the trifacet. The trifacet is only deactivable because the US government managed to recover and study at least one before the world eneded.

I honestly didn't see any flag in code that checked did you read trifacet handling procedures or not (could have missed it) I partially agree i want to add couple changes later that will allow you to deactivate rest if you bring to Hub-01 broken and let them work their magic for a bit (but not right now as it is already quite a lot of code in this)

[Vgoloshivskiy]

I'm not particularily sold on the player being able to disable the rest of the drones beyond the trifacet. The trifacet is only deactivable because the US government managed to recover and study at least one before the world eneded.

Just added checks might need more testing than i did, but should looks nice

[Vgoloshivskiy]

Adding more deactivation manuals feels like a copout. I think you should just make it impossible for the player to disable the Yrax bots other than the Trifacet.

You can keep the option to deliver inactive drones to the Hub, but the player has to find them in inactive forms. You can add more dormant Yrax that work similar to the Sphenocoronae in future PRs.

I did't want for it to feel like copout, I wanted something like this to begin with. It is not hard to remove this functionality, you can accomplish this by just removing revert to item from yrax bots json. I might add spawn locations with inactive Yrax but i wanted there to be possibility to disable some extremly dangerous Yrax. Monolith is a dormant Sphenocoronae but I can't really deliver it as it is still a monster and not an item that i can put in car. Edit:-> I also don't see lore issue goverment captured and studied at least one model and probably already had some data on others, robofac is robot focused researchers thus the name, you deliver them broken to finish research, they have mediocre AI that can help them in studying it.

[github-actions[bot]]

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand

• A broken quadraphract leg, secured to the roof for transportation. Not functional, and hopefully never be.
• A broken quadraphract, secured to the roof for transportation. Not functional, and hopefully never be.
• The hostile triakis violently unfolds just clear of your hand!
• [Deliver a broken triakis drone.]
• [Deliver a deactivated triakis.]
• [Drag in broken quadraphract leg.]
• [Drag in broken quadraphract.]
• inactive triakis
• tied-down broken quadraphract
• tied-down broken quadraphract leg

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary

• If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
• For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

[MikasaTanikawa]

@Vgoloshivskiy please add migration for new manual id and at https://github.com/Vgoloshivskiy/Cataclysm-DDA/blob/bf05b72514cbee078b6a37c86791c585c5795549/data/json/npcs/robofac/robofac_intercom/robofac_intercom_trades.json#L291 should be "TALK_ROBOFAC_INTERCOM_SELL_BROKEN_YRAX_DELTA"