CleverRaven
Gun Cleaning update
Summary
Bugfixes "Minor fixes in gun cleaning"
Purpose of change
I saw in #76187 that pipe cleaners create cotton out of thin air. I've fixed that in another PR. Then I've taken a look at the different types of gun cleaning and adjusted them as needed. In many cases the cleaning cloth is now reusable. I am curious if there is some way to make the cloth dirty.
Describe the solution
Adds pipe dowel and then adjusts and adds a different cleaning type. Will add the fault to mend in flintlocks.
Describe alternatives you've considered
Leaving this to someone else but other people are slow when I can fix it myself fast.
Testing
tbd
Additional context
What exactly was the problem initially? In general the way you clean a gun is you take a rod, put a piece of cloth on it, apply gun cleaning solution, and ram it through the barrel. Previously the rod was the pipe cleaner crafted from a wire, the consumable patch (in this case we were treating the dirtying of the cloth as its destruction/removal from the game world) and the consumable solvent were the mend task consumables. So the pipe cleaner was basically this:
What exactly was the problem initially? In general the way you clean a gun is you take a rod, put a piece of cloth on it, apply gun cleaning solution, and ram it through the barrel. Previously the rod was the pipe cleaner crafted from a wire, the consumable patch (in this case we were treating the dirtying of the cloth as its destruction/removal from the game world) and the consumable solvent were the mend task consumables. So the pipe cleaner was basically this:
What you shared isn't a pipe cleaner. It's a rod. Our item is an actual pipe cleaner.
{
"id": "pipe_cleaner",
"type": "GENERIC",
"name": { "str": "pipe cleaner" },
"description": "A tool designed to clean the interior surface of pipes, bottles, and similar objects. This one is thin enough to be used for cleaning firearm barrels from dirt and fouling.",
"weight": "50 g",
"volume": "250 ml",
"price": "5 USD",
"price_postapoc": "50 cent",
"material": [ "steel", "cotton" ],
"symbol": ";",
"color": "light_gray"
},
Note the materials steel and cotton. The pipe cleaner recipe had zero cotton in it. Now it accurately makes a diy pipe cleaner.
What exactly was the problem initially? In general the way you clean a gun is you take a rod, put a piece of cloth on it, apply gun cleaning solution, and ram it through the barrel. Previously the rod was the pipe cleaner crafted from a wire, the consumable patch (in this case we were treating the dirtying of the cloth as its destruction/removal from the game world) and the consumable solvent were the mend task consumables. So the pipe cleaner was basically this:
What you shared isn't a pipe cleaner. It's a rod. Our item is an actual pipe cleaner.
{ "id": "pipe_cleaner", "type": "GENERIC", "name": { "str": "pipe cleaner" }, "description": "A tool designed to clean the interior surface of pipes, bottles, and similar objects. This one is thin enough to be used for cleaning firearm barrels from dirt and fouling.", "weight": "50 g", "volume": "250 ml", "price": "5 USD", "price_postapoc": "50 cent", "material": [ "steel", "cotton" ], "symbol": ";", "color": "light_gray" },Note the materials steel and cotton. The pipe cleaner recipe had zero cotton in it. Now it accurately makes a diy pipe cleaner.
When you say "pipe cleaner" do you mean this?
When you say "pipe cleaner" do you mean this?
No our pipe cleaners represented this. https://otistec.com/100-pack-pipe-cleaners/
Just so we're on the same page, this is pretty much what cleaning a gun in survival conditions is mostly like:
I’m familiar with that and it’s represented in the quick cleaning action.
On Thu, Sep 5, 2024 at 8:22 PM misterprimus @.***> wrote:
Just so we're on the same page, this is pretty much what cleaning a gun in survival conditions is mostly like: gunclean.gif (view on web) https://github.com/user-attachments/assets/bfbd521c-5396-4aca-b741-332157f7752b
— Reply to this email directly, view it on GitHub https://github.com/CleverRaven/Cataclysm-DDA/pull/76229#issuecomment-2332997667, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM6UAQB33OCNVNRCFQZGS5DZVD7UBAVCNFSM6AAAAABNXRXHHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZSHE4TONRWG4 . You are receiving this because you authored the thread.Message ID: @.***>
I’m familiar with that and it’s represented in the quick cleaning action. C … On Thu, Sep 5, 2024 at 8:22 PM misterprimus @.> wrote: Just so we're on the same page, this is pretty much what cleaning a gun in survival conditions is mostly like: gunclean.gif (view on web) https://github.com/user-attachments/assets/bfbd521c-5396-4aca-b741-332157f7752b — Reply to this email directly, view it on GitHub <#76229 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM6UAQB33OCNVNRCFQZGS5DZVD7UBAVCNFSM6AAAAABNXRXHHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZSHE4TONRWG4 . You are receiving this because you authored the thread.Message ID: @.>
Understood. But then are pipe cleaners going to be totally unnecessary for cleaning a gun? Because in all my years of cleaning guns, I've never used a pipe cleaner like that or seen one in a retail cleaning kit. Most gun cleaning kits are basically this:
And in my personal experience, the rod + a patch with solvent/oil is basically what's used 99% of the time. So I'm still a little confused as to what the pipe cleaner (anatomically correct as it may be in your adjusted recipe) is supposed to do as far as role fulfillment is concerned for barrel-cleaning. The barrel-cleaning phase is done with a rod, cloth, and solvent. Barrel brushing, in the few instances when it is done, is done with copper/brass brushes. Neither of these would be accomplished with the pipe cleaners you posted.
I’m familiar with that and it’s represented in the quick cleaning action. C … On Thu, Sep 5, 2024 at 8:22 PM misterprimus @.> wrote: Just so we're on the same page, this is pretty much what cleaning a gun in survival conditions is mostly like: gunclean.gif (view on web) https://github.com/user-attachments/assets/bfbd521c-5396-4aca-b741-332157f7752b — Reply to this email directly, view it on GitHub <#76229 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM6UAQB33OCNVNRCFQZGS5DZVD7UBAVCNFSM6AAAAABNXRXHHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZSHE4TONRWG4 . You are receiving this because you authored the thread.Message ID: _@**.**_>
Understood. But then are pipe cleaners going to be totally unnecessary for cleaning a gun? Because in all my years of cleaning guns, I've never used a pipe cleaner like that or seen one in a retail cleaning kit. Most gun cleaning kits are basically this:
And in my personal experience, the rod + a patch with solvent/oil is basically what's used 99% of the time. So I'm still a little confused as to what the pipe cleaner (anatomically correct as it may be in your adjusted recipe) is supposed to do as far as role fulfillment is concerned for barrel-cleaning. The barrel-cleaning phase is done with a rod, cloth, and solvent. Barrel brushing, in the few instances when it is done, is done with copper/brass brushes. Neither of these would be accomplished with the pipe cleaners you posted.
I only use them on once a year or longer full disassemble and cleaning. I don't think they are an ideal tool for it as the main tool but I was being kind to the pc and suggesting it could be used assuming they lacked a real gun kit. I'm personally fine with removing it entirely but the other things are going to be much harder for the player to self craft.
I’m familiar with that and it’s represented in the quick cleaning action. C … On Thu, Sep 5, 2024 at 8:22 PM misterprimus @.> wrote: Just so we're on the same page, this is pretty much what cleaning a gun in survival conditions is mostly like: gunclean.gif (view on web) https://github.com/user-attachments/assets/bfbd521c-5396-4aca-b741-332157f7752b — Reply to this email directly, view it on GitHub <#76229 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM6UAQB33OCNVNRCFQZGS5DZVD7UBAVCNFSM6AAAAABNXRXHHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZSHE4TONRWG4 . You are receiving this because you authored the thread.Message ID: _@**.**_>
Understood. But then are pipe cleaners going to be totally unnecessary for cleaning a gun? Because in all my years of cleaning guns, I've never used a pipe cleaner like that or seen one in a retail cleaning kit. Most gun cleaning kits are basically this:
And in my personal experience, the rod + a patch with solvent/oil is basically what's used 99% of the time. So I'm still a little confused as to what the pipe cleaner (anatomically correct as it may be in your adjusted recipe) is supposed to do as far as role fulfillment is concerned for barrel-cleaning. The barrel-cleaning phase is done with a rod, cloth, and solvent. Barrel brushing, in the few instances when it is done, is done with copper/brass brushes. Neither of these would be accomplished with the pipe cleaners you posted.
I only use them on once a year or longer full disassemble and cleaning. I don't think they are an ideal tool for it as the main tool but I was being kind to the pc and suggesting it could be used assuming they lacked a real gun kit. I'm personally fine with removing it entirely but the other things are going to be much harder for the player to self craft.
Lots of things can function as the rod. A long screwdriver for example.
Chopstick (eating utensil) for smaller size barrels like that of a handgun. Or a straightened coat hanger (the "wire" as it was in the past).
And that's if you're ramming. If you pull (which would accomplish a similar result), you can just tie a wire or a string to the cloth and pull. https://www.youtube.com/watch?v=pDHYkWD7jYs
I’m familiar with that and it’s represented in the quick cleaning action. C … On Thu, Sep 5, 2024 at 8:22 PM misterprimus @.> wrote: Just so we're on the same page, this is pretty much what cleaning a gun in survival conditions is mostly like: gunclean.gif (view on web) https://github.com/user-attachments/assets/bfbd521c-5396-4aca-b741-332157f7752b — Reply to this email directly, view it on GitHub <#76229 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM6UAQB33OCNVNRCFQZGS5DZVD7UBAVCNFSM6AAAAABNXRXHHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZSHE4TONRWG4 . You are receiving this because you authored the thread.Message ID: _@**.**_>
Understood. But then are pipe cleaners going to be totally unnecessary for cleaning a gun? Because in all my years of cleaning guns, I've never used a pipe cleaner like that or seen one in a retail cleaning kit. Most gun cleaning kits are basically this:
I only use them on once a year or longer full disassemble and cleaning. I don't think they are an ideal tool for it as the main tool but I was being kind to the pc and suggesting it could be used assuming they lacked a real gun kit. I'm personally fine with removing it entirely but the other things are going to be much harder for the player to self craft.
Lots of things can function as the rod. A long screwdriver for example.
Chopstick (eating utensil) for smaller size barrels like that of a handgun. Or a straightened coat hanger (the "wire" as it was in the past).
And that's if you're ramming. If you pull (which would accomplish a similar result), you can just tie a wire or a string to the cloth and pull. https://www.youtube.com/watch?v=pDHYkWD7jYs
We don’t represent individual long screwdrivers so they’d have to be a screwdriver set, chopsticks are rare in game. I’m not debating you but you aren’t suggesting changes that I can accept as additions and substractions from the recipe. What I’m saying here is that if you have useful suggestions make them easy for me to work with. I’m trying to put my children to sleep so anything else outside of any suggested code changes from you is beyond the scope of what I’m doing in this PR.
and
Then I'd say let a "wire" (incl. mild steel, etc...) or even a "rope" or "long string" be usable as the "tool" needed to clean a gun. And require the cleaning step to consume a cotton patch and some solvent/cleaning solution. Does that sound agreeable?
and
Then I'd say let a "wire" (incl. mild steel, etc...) or even a "rope" or "long string" be usable as the "tool" needed to clean a gun. And require the cleaning step to consume a cotton patch and some solvent/cleaning solution. Does that sound agreeable?
That does. Do you mind adding it in this PR as code suggestions on the files tab?
Something else I thought of is perhaps creating a "makeshift gun cleaning rod" out of a wire (any kind of wire) to simulate the process of bending a wire into a shape needed to be used for such a purpose (bending it in two for example). Kind of like a pipe is "shaped" into a makeshift crowbar. But it's your PR so up to you what sort of direction you want to go if you want to do what I recommended and just use a wire directly for the cleaning process. LMK and I can make that change probably.
Considering plastic coating is irrelevant to its function, raw copper wire(copper_wire) is also a suitable component
