Clean water put into water heater instantly spoils

[Psithief]

Describe the bug

After enough time in the game world has passed, putting clean water into a water heater instantly turns it into water.

Attach save file

Water Test World-trimmed.tar.gz

Steps to reproduce

1. Spawn:
   1. a very large battery,
   2. a household water heater,
   3. a disconnected water purifier.
   4. a steel drum (100L)
2. Place the battery and purifier to make a grid.
3. Fill the steel drum from a pond.
4. Use the water purifier to purify the water in the steel drum.
5. Refill the water heater with the clean water from the steel drum.
6. Examine the water heater. It should have clean water.
7. Pour the clean water from the water heater into the steel drum.
8. In the debug menu, advance the game time by one year.
9. Refill the water heater with the clean water.
10. Examine the water heater. It will now just have water.

Expected behavior

The clean water does not instantly spoil.

Screenshots

No response

Versions and configuration

• OS: Windows
  • OS Version: 10.…
• Game Version: cdda-experimental-2024-08-11-0857 2d4e043 [64-bit]
• Graphics Version: Tiles
• Game Language: System language []
• Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Portal Storms Ignore NPCs [personal_portal_storms], Slowdown Fungal Growth [no_fungal_growth], Standard combat test suite [standard_combat_test], TropiCataclysm [tropicata] ]

Additional context

#74353 #74863 @nornagon

[XygenSS]

/confirmed

Some furniture does spoil the water while others don't.

1. Purify a drum full of water
2. Timeskip a year ahead, and then:

• Pouring it into a water heater (as described in the report) does spoil the water
• Pouring it into a standing tank does
• Pouring the clean water into another drum (whether in inventory or nearby) does not spoil the water
• Pouring it into a bathtub does not
• Pouring it into a toilet does not /
• OS: Windows
  • OS Version: 10.0.19045.4780 (22H2)
• Game Version: ae2b99e [64-bit]
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Portal Storms Ignore NPCs [personal_portal_storms], Slowdown Fungal Growth [no_fungal_growth] ]\

[suchacomic]

issue is still present in the latest experimental build 2024-11-21-1525.

[deltanedas]

haven't debugged it but i believe this is from the water's last_temp_check being 0 after filling the keg, so when the item gets added to its tile it instantly reverts to dirty water. still happens on 22f9e267 at least