Cataclysm-DDA icon indicating copy to clipboard operation
Cataclysm-DDA copied to clipboard

Removed descriptions for reloaded and black powder rounds

Open Uwuewsky opened this issue 1 year ago • 3 comments

Summary

Interface "Removed descriptions for reloaded and black powder rounds"

Purpose of change

Initially, I moved the repeating text into snippets, because 99.99% of such descriptions are simply a description of the factory round + a small explanation. It was all good, but not being able to add some text to the parent item description without copying it makes it less useful, and the text becomes more cluttered. And it's a bit hard to maintain.

Describe the solution

So I removed those descriptions in favor of effect (RECYCLED, BLACKPOWDER, MATCHHEAD) descriptions. There are about 5 unchanged exceptions where this description differed from a simple concatenation with a "snippet".

Also, I changed the description of the effect in item.cpp similar to what was in the descriptions of the items (see third commit).

The second commit contains unrelated minor fixes that I noticed. I didn't put them in a separate PR because of possible merge conflicts.

Describe alternatives you've considered

Testing

Almost every ammo has a description of the parent. ammo_new1

Additional context

Uwuewsky avatar Aug 22 '24 05:08 Uwuewsky

you seem to have put the answer to 'alternatives you considered' into the 'purpose of change' section, and omitted the rationale for this entirely. what is the objective? what makes that objective necessary?

esotericist avatar Aug 23 '24 10:08 esotericist

in general, the rationale here is the same as in #71138

Uwuewsky avatar Aug 24 '24 14:08 Uwuewsky

In short, your goal is reducing redundancy in descriptive strings in order to reduce the number of distinct strings for translation and translator workload. In the future please just copy something like the above into related prs to give people context.

kevingranade avatar Aug 24 '24 15:08 kevingranade