Cataclysm-DDA icon indicating copy to clipboard operation
Cataclysm-DDA copied to clipboard

backport #72334

Open GuardianDll opened this issue 1 year ago • 3 comments

Summary

None

Purpose of change

Backport #72334

Additional context

Dear Santa, i will never, ever make an omnibus PR, at least one bigger than 50 lines

GuardianDll avatar Aug 20 '24 09:08 GuardianDll

The codebase had diverged from 0.H for 2.5 months by this point, how confident are you that this big of a backport into 0.H doesn't break more stuff? Content that works unideally is preferable to instability for 0.H imo, especially this late into the cycle.

harakka avatar Aug 20 '24 12:08 harakka

If it was good to merge back then (and I haven't seen any issues arising from it, though of course there could be) then it should be good to merge now. The main thing I would be worried about is any possible merge conflicts which had to be manually resolved.

RenechCDDA avatar Aug 20 '24 12:08 RenechCDDA

I ported it completely manually fyi, so no conflicts should be created

GuardianDll avatar Aug 20 '24 12:08 GuardianDll

Ugh this backport works but I want the transparent code for Snups work on bags that flashlights can shine through and also for vampire suffering in daylight. Is there a better way we want transparent or is it just getting pulled because it's dead code right now without the photosynthesis stuff?

Maleclypse avatar Aug 30 '24 22:08 Maleclypse

Snup code about transparent pockets were not approved yet, for there is no way to attach flashlight to a gun, as it would be the most common way to light the entire area. Until it would be made, it is effectively a dead code.

Besides, this is a backport

GuardianDll avatar Aug 30 '24 22:08 GuardianDll