Cataclysm-DDA icon indicating copy to clipboard operation
Cataclysm-DDA copied to clipboard

Bone audit - 1/?

Open Karol1223 opened this issue 8 months ago • 1 comments

Summary

None

Purpose of change

~~Our bone items were, although good, still not exactly normalized and kind of all over the place. This, combined with #74328 which finally allows me to make corpses leave bones behind as they decay (but need some new bone types, so you don't get to make bone broth out of dessicated rotten bones) requires me to finally step up and set the stage. I really wanna add decay fields.~~ Since #74462 is in limbo and I have no idea what to do with myself, this is devolving to just auditing some currently existing bone items. Nothing new is going to be added anymore.

Describe the solution

Default bones

  • Normalized to be based off an average male human femur, which means the weight, volume, and length went slightly up
  • Added a dynamic to-hit calculation as well as some shitty bash damage
  • Added 171kcal
  • Chain the tainted bone with copy-from from the base, remove its kcal
  • Correct the human bone's vitamins to go in line with the default's, gave it the meat allergen vitamin just in case

Weird huge museum bone thing

  • Normalize the dimensions to be based off an African elephant femur
  • Change category to generic, ain't nobody eating a 20l bone
  • Changed the length modifier to long from short

Bone meals

  • Normalized to 35kcal per serving
  • Added baseline calcium and meat allergen vitamins
  • Adjusted the volume, density based off flour
  • Chained the tainted version to the default via copy-from

Skulls

  • Change category from spare parts to other
  • Gave skulls smaller than a single bone item their own milling recipes

Misc shit

  • Made cowrie jewelry unsalvageable
  • Removed the bone skewer's to-hit since it had no damage defined anyway
  • Removed tainted bones from one of Magiclysm profession itemgroups. I couldn't find a way to make them make sense in there. In the future I'd like to replace them with tainted bone shards when/if I get to add that item, but for now the druids are two tainted bones poorer
  • Cleaned up the syntax for fur in that same itemgroup while I was here

Describe alternatives you've considered

  • Add some cowrie shell items that the cowrie jewelry could disassemble into. Not viable since different pieces would likely use different shell sizes

Testing

Additional context

  • https://www.researchgate.net/figure/The-comparison-of-osteometric-measurements-of-the-femurs-in-females-and-males_tbl1_237084956 - source for human femur dimensions - volume multiplied by 1.15x to account for the fact that the bone is not a perfect cylinder image
  • my source for the weight honestly it sucks, but I couldn't find anything else?
  • https://www.researchgate.net/publication/283482771_Kinematics_and_Comparative_Anatomy_of_Some_Limb_Bones_of_the_African_Elephant_Loxodonta_africana_and_Large_Domestic_Animals - source for elephant femur dimensions - volume also multiplied by 1.15x, weight calculated proportionally from human femur
  • https://www.nutritionvalue.org/public_ingredient_8521.html?size=290+g source for bonemeal nutritional values, also used for the basic bone items - no better data for non-milled bones that I could find, and calculating it manually gives it 3x as much calcium as same amount of bone meal would give
  • bone meal density based off flour

Karol1223 avatar Jun 07 '24 10:06 Karol1223