Cataclysm-DDA icon indicating copy to clipboard operation
Cataclysm-DDA copied to clipboard

[ Aftershock ] Adjust some trait names and descriptions to Aftershock lore

Open Maleclypse opened this issue 1 year ago • 4 comments

Summary

None

Purpose of change

Adjust traits to Aftershock Lore

Describe the solution

Adds new names and descriptions.

Describe alternatives you've considered

Blacklisting these traits

Testing

Additional context

Maleclypse avatar May 11 '24 04:05 Maleclypse

I kinda feel like we might not need to actually overwrite these traits over just making new ones.

Most of their hardcoded effects are partially obsolete now.

John-Candlebury avatar May 12 '24 00:05 John-Candlebury

I kinda feel like we might not need to actually overwrite these traits over just making new ones.

Most of their hardcoded effects are partially obsolete now.

So just create new id's for all of them and we can utilize them in EOCs and dialogue as we decide to?

Maleclypse avatar May 12 '24 03:05 Maleclypse

Yeah I think it might make maintenance easier in the long run.

John-Candlebury avatar May 12 '24 03:05 John-Candlebury

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • As a member of the Astrographic and Gatepoint Division you are responsible for spreading the boundaries of the Frontiers and protecting interstellar travel. This gives you wide ranging latitude when it comes to addressing threats to interstellar travel. Does this technically make you a member of UICA's very own secret police? Yes, yes it does.
  • Pinkerton
  • UICA Astrographic and Gatepoint Agent

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

github-actions[bot] avatar May 14 '24 03:05 github-actions[bot]