Cataclysm-DDA icon indicating copy to clipboard operation
Cataclysm-DDA copied to clipboard

Error in displaying the book title in the recipes

Open IdleSol opened this issue 1 year ago • 1 comments

Describe the bug

I'm not sure if this is a bug or a suggestion. Books have title variations. But only the basic title is displayed in the recipes. Here's an example.

Pict1

I have a book in my trunk with the title "The Poor Man's James Bond" in it. This is one of the variants for the "AAA Guide" book. https://github.com/CleverRaven/Cataclysm-DDA/blob/709ea9f83d73ce1dc115a7014071d591d42a80ae/data/json/items/book/driving.json#L181

And in the crafting menu, in the recipes it shows up as: "AAA Guide." Pict2

This can be misleading to the player. Imagine you are trying to find a book that has a recipe in it. You know the name, but the book is nowhere to be found because it shows a different name.

Attach save file

n/a

Steps to reproduce

n/a

Expected behavior

Correct display of book titles

Screenshots

No response

Versions and configuration

cdda-windows-tiles-x64-2024-04-23-1301

Additional context

On a separate note, attention needs to be paid to quests. I don't know if there are such problems now, but they may be later. For example, the book for the engineer at the refugee center, will have multiple title variations.

https://github.com/CleverRaven/Cataclysm-DDA/blob/709ea9f83d73ce1dc115a7014071d591d42a80ae/data/json/npcs/refugee_center/surface_refugees/NPC_Jenny_Forcette.json#L658

Ah, it already has multiple titles. You know how to make the players suffer.

P.S. Add to this the translation into other languages and you get double suffering.

IdleSol avatar Apr 24 '24 15:04 IdleSol

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

github-actions[bot] avatar May 24 '24 16:05 github-actions[bot]