Remove legacy lab content.

[kevingranade]

Summary

None

Purpose of change

Rip off the band-aid and stop the oldest of the old labs from spawning.

Describe the solution

This DOES remove: Standalone labs, ice labs, ant labs, and "lab escape" starts.

This DOES NOT remove: Procedurally generated secret labs under basements, prisons, and the brick lab complex. Central Lab, Tower Labs, lab subways, or any of the newer microlabs, LIXA, or TCL.

Describe alternatives you've considered

Leaving ancient and creaky lab content in forever, preventing progress to better designed facilities. Going further and ripping out central labs, tower labs, and subways, but I got some feedback that someone might be interested in reworking these, and I agree they could be salvageable. Ripping out the secret labs, need to take a little more time with these and fix up mapgen around them because they aren't standalone.

Testing

Ran a bunch of mapgen with no (new) problems.

[John-Candlebury]

Its been a while since I confirmed this, but it used to be that the secret -4 layer subway depends on legacy labs being present to generate, despite being used by newer lab content.

It might be worth verifying that this is no longer the case (I cant really build this myself atm).

[Procyonae]

The omts all need migrating in \data\json\obsolete_overmap_terrain.json so saves don't throw 100 errors

[I-am-Erk]

Don't forget that the free merchant doctor sends you to an ice lab

[KeremBabaG]

[I-am-Erk]

Do we have a nanofab in any of the existing facilities? It should probably be globally unique but we should have one.

[John-Candlebury]

Do we have a nanofab in any of the existing facilities? It should probably be globally unique but we should have one.

None exist outside lab finales in unmodded games.

[I-am-Erk]

We probably need at least an issue for the missing content, I'd suggest we put the nanofab into a special unique subway lab, and make a mutable ice lab. There are probably some other things we are forgetting.

For those reading along, these aren't being removed, the legacy labs are still available in several locations.

I'd suggest we put the ice lab under the surface research facility and make it unique.

[RenechCDDA]

Could probably just add the control panel to the office tower spawn.

[Procyonae]

We probably need at least an issue for the missing content

There is this https://github.com/orgs/CleverRaven/projects/16 for what it's worth

[I-am-Erk]

We probably need at least an issue for the missing content

There is this https://github.com/orgs/CleverRaven/projects/16 for what it's worth

Ah perfect

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.