Graphical setting causes black lines in tilesets

[EternalLaughter]

Describe the bug

It seems that enabling linear Scaling in Graphic settings causes black lines in the tilesets (Chibi Ultica tested mostly, but seen in others) The issue seems to be worst with opengl and opengles2. With software or opengles the issue is mitigated. In addition this issue does not happen with with nearest neighbour scaling, or no scaling, regardless of the renderer chosen.

Attach save file

N/A

Steps to reproduce

Swap to opengl\opengles2 and linear scaling - see black lines in tileset when you zoom in, for the last two zoom levels. The issue is very apparent in opengl\opengles2, and much less so in software and opengles. See screenshots.

Expected behavior

I'd expect no lines.

Screenshots

Forest opengles linear

Forest opengl linear

Road opengles linear

Road opengl linear

Road opengl Nearest Neighbour

Road software linear

Road software Nearest Neighbour

Versions and configuration

• OS: Linux
  • OS Version:
• Game Version: cdda-experimental-2024-04-11-1603 9819962 [64-bit]
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Portal Storms Ignore NPCs [personal_portal_storms], Slowdown Fungal Growth [no_fungal_growth] ]

Additional context

No response

[ZhilkinSerg]

What's the SDL version reported in debug.log? There should be something like this:

16:50:51.146 INFO : SDL version used during compile is 2.26.4
16:50:51.146 INFO : SDL version used during linking and in runtime is 2.26.4

Similar issue was fixed for Android by upgrading SDL version in https://github.com/CleverRaven/Cataclysm-DDA/pull/72154

[EternalLaughter]

SDL version listed is: 12:23:36.083 INFO : SDL version used during compile is 2.0.20 12:23:36.083 INFO : SDL version used during linking and in runtime is 2.0.20 12:23:36.225 INFO : SDL render devices: software, opengl, opengles2, opengles

[harakka]

What hardware and Linux distro are you on?

[katemonster33]

confirmed on windows and MSVC. swapped renderer to opengl, using 2x scaling, linear

[EternalLaughter]

What hardware and Linux distro are you on?

Fedora 39 and Nvidia - but i see it got reproduced in windows below as well, so shouldn't be related.

[ZhilkinSerg]

What hardware and Linux distro are you on?

Fedora 39 and Nvidia - but i see it got reproduced in windows below as well, so shouldn't be related.

Yeah, there is probably bug in SDL related to rounding.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[RenechCDDA]

confirmed on windows and MSVC. swapped renderer to opengl, using 2x scaling, linear

marking as confirmed, then.