Evac shelter parameterisation

[Procyonae]

Summary

None

Purpose of change

Evac centre variants nice, needless bloat and repetition not so much More variants can be added without further repetition 289 lines less in specials.json means my mouse wheel won't break as fast

Describe the solution

Requires #72558 and #72560

Combines the 4 layouts and 3 versions of each fully built evac centre into one special, changing the combined occurrences of [ 0,24 ] to the slightly more sane [ 2,9 ] Combines the 4 layouts of the unfinished evac centre into a separate special, changing the combined occurrences of [ 0,4 ] to [ 1,3 ] The infested versions now have zed spawns in the basement other than the challenge scenario where you spawn there in line with the used version Changes zed spawn method to be the same for infested/used variants Removes unwanted auto roofs above unfinished variant windows and stairs Adds a shared palette that the variant palettes inherit from Evac shelters have a random roof terrain

Describe alternatives you've considered

Complicating the vandal/used versions by keeping a chance for zeds in each at special scope but that feels unneeded

A solution to #72511 would cut this down by 130 lines

Some way to distinguish the overmap names using special scoped snippets would be cool so each evac centre could have it's own letter-number combo like "evac shelter A-23". I've left that one in in the hopes someone finds a way to do this rather than remove it and it be forgotten about. (I'm not counting this as a regression because you could already find multiple "evac shelter A-23" etc)

Testing

Tested spawning all variants via tweaking distribution weights Tested challenge and default scenarios

Additional context

[RenechCDDA]

Hah, I was going to ask you to update the Character constructor but you already found it. Good on you, string searching removed IDs!

[Procyonae]

Hah, I was going to ask you to update the Character constructor but you already found it. Good on you, string searching removed IDs!

I think I just chanced upon it actually '^^

[Procyonae]

Crabapples I just remembered basecamps exist and this presumably breaks them >_> Yup need to add parameter handling to basecamp recipe_group :c They need om_match type handling too while I'm at it... Here I were thinking I'd got away with No Hope being easy to deal with for once

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[github-actions[bot]]

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand

• Vandalised Evac Center

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary

• If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
• For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.