Cataclysm-DDA
Cataclysm-DDA copied to clipboard
CleverRaven
Remove "Rapid strike" technique from knives
Summary
Balance "Remove rapid strike from knives"
Purpose of change
Knives have very low attack costs and the technique amplifies this property, giving some knives inflated DPS.
Describe the solution
I removed the technique from all weapons in the "knives" category.
Describe alternatives you've considered
Discuss if each knife individually justifies having the technique.
Testing
Additional context
Justification: all the knife attacks are rapid to begin with.
The rapid strike technique could be reserved for a normally slow weapon that is utilized as fast as a knife like a katana maybe.
The failing tests are unrelated apparently, should be ready to merge.
I am amazed this isn't breaking any dps tests but I think I see the point that knives with rapid strike are double counting their speed.
Finally a combat knife isn't gonna be on par with a sword.
well, knife_combat (i.e. "National Guard bayonet") was missed from this PR so yeah, the above is still true 😅
I wonder, there are bunch of decrements in damage aside the RAPID removal. From commits I assume this is to comply to existing DPS tests... but should the fix be the other way around? New DPS expectations from this removal, so "old tests are wrong". Just a thought
Finally a combat knife isn't gonna be on par with a sword.
well,
knife_combat(i.e. "National Guard bayonet") was missed from this PR so yeah, the above is still true 😅I wonder, there are bunch of decrements in damage aside the RAPID removal. From commits I assume this is to comply to existing DPS tests... but should the fix be the other way around? New DPS expectations from this removal, so "old tests are wrong". Just a thought
The dps tests are set based around the planned scale of damage by specific weapons. There's a document in the md's about how they were chosen