Cataclysm-DDA icon indicating copy to clipboard operation
Cataclysm-DDA copied to clipboard

Replace `stdafx.h` with `pch/main-pch.hpp`

Open alef opened this issue 1 year ago • 1 comments

Summary

Build "Use one precompiled header"

Purpose of change

Since stdafx.h and pch/main-pch.hpp are quite similar, let us use only one.

Describe the solution

  • [x] Merged stdafx.h content into pch/main-pch.hpp
  • [x] Changed the msvc-full-features solution files to point to the new include
  • [x] stdafx.cpp includes the new pch

Describe alternatives you've considered

Testing

Compile and link the following:

  • [x] Visual Studio msvc-full-features Solution
  • [x] Linux Makefile with TILES=1 SOUND=1 CCACHE=1 PCH=1
  • [x] CMake MSYS2/MINGW/UCRT64
  • [x] CMake MSVC

Additional context

Keep this in draft for some time to double check local builds performance.

alef avatar Feb 18 '24 18:02 alef

Are all the project file changes needed, or are those some intermediate steps? Everything should be expressable in Cataclysm-common.props.

akrieger avatar Feb 21 '24 00:02 akrieger