Cataclysm-DDA icon indicating copy to clipboard operation
Cataclysm-DDA copied to clipboard

NPCs stop reading if player uses stairs

Open pwalsh0 opened this issue 1 year ago • 5 comments

Describe the bug

As subject. Imagine a "training montage" with lots of npcs in library, all carefully ordered to study from a book or tablet.

This training montage gets interrupted if the player uses a stairs briefly then returns - all the npcs will stop reading - and then require tedious refreshing of orders.

Doesn't seem to interrupt crafting or other activities, just reading.

Attach save file

Munroe Falls-trimmed.tar.gz

Steps to reproduce

Load save. Check if npcs are reading, if not give them orders. Not sure if loading save interrupts this as well. Note npcs nearby are reading books. Note they will stay there and not follow. Go up stairs then back down. Now note npcs have stopped reading and are following player again.

Expected behavior

NPCs should not stop reading just because the player uses a stairs.

Screenshots

No response

Versions and configuration

  • OS: Linux
    • OS Version:
  • Game Version: ab8d84c [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Portal Storms Ignore NPCs [personal_portal_storms], Slowdown Fungal Growth [no_fungal_growth], Mythical Martial Arts [MMA], Bombastic Perks [bombastic_perks] ]

Additional context

No response

pwalsh0 avatar Feb 10 '24 09:02 pwalsh0

That should have been fixed when 3D view was made mandatory. If your game version is older than that disabling 3D view should get rid of the symptoms (it was caused by light checking code that failed to actually get hold of the light level on other levels).

If the version is a new one there is still a problem, but walking downstairs and ordering companions to read, return back up, and then down again does not interrupt reading for me using code downloaded and compiled earlier today.

PatrikLundell avatar Feb 10 '24 16:02 PatrikLundell

Duplicate of #68212

harakka avatar Feb 11 '24 10:02 harakka

The version from above is cdda-experimental-2024-02-10-0823 - is that recent enough?

edit: @PatrikLundell confirmed again with latest experimental 2024-02-13-1429

In this case the "reading room" is underground with a lamp - maybe that makes a difference compared to npcs reading in naturally lit area? In OP I said that crafting wasn't affected. There is a workbench at ground level with another npc crafting away - and he does not get interrupted by player stairs travel. So suspect lighting problem?

pwalsh0 avatar Feb 11 '24 19:02 pwalsh0

Tested some more - and confirmed this only happens when reading with artificial light source.

If you bring the guys outdoors and tell them to read under natural light they don't get interrupted.

pwalsh0 avatar Feb 13 '24 19:02 pwalsh0

I have had my NPC stop other tasks in a similar fashion when I change z-levels, not just reading. And yes, underground I was using artificial lights.

ashGlaw avatar Feb 14 '24 19:02 ashGlaw

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

github-actions[bot] avatar Mar 20 '24 06:03 github-actions[bot]