Cataclysm-DDA icon indicating copy to clipboard operation
Cataclysm-DDA copied to clipboard

Multiple errors in JSON data

Open WarBarista opened this issue 1 year ago • 4 comments

Describe the bug

In attempting to create the character, i get a lot of errors connected to elements' id, name, description, type and copy-from being invalid/misplaced in JSON data

Attach save file

Профетс-trimmed.tar.gz

Steps to reproduce

  1. Create new world
  2. Attempt to create a character
  3. get the errors

Expected behavior

I haven't noticed any severe problems yet, but error is error, so it shouldn't appear

Screenshots

Снимок экрана (63) Снимок экрана (66) Снимок экрана (68)

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.22621.3007 (22H2)
  • Game Version: e286c6e [64-bit]
  • Graphics Version: Tiles
  • Game Language: Системный язык []
  • Mods loaded: [ Тёмные Дни Впереди [dda], Отключить потребности у НПС [no_npc_food], Портальные штормы игнорируют НПС [personal_portal_storms], Медленный рост фунгалоидов [no_fungal_growth], Aftershock [aftershock], Разум над материей [mindovermatter], Развитая XEDRA [xedra_evolved] ]

Additional context

No response

WarBarista avatar Feb 04 '24 11:02 WarBarista

Invalid. You modded locally and broke it then tried to load again without reloading the game. Not an issue with our distribution.

(continued from above) ERROR : D:\a\Cataclysm-DDA\Cataclysm-DDA\src\main_menu.cpp:986 [new_character_tab] Error: Json error: data/mods/BombasticPerks/perks.json:242:22: <color_white><color_cyan>Inline enchantment INLINE_ENCH_Лёгкое засыпание_0 cannot be created as an enchantment already has this id.</color>

RenechCDDA avatar Feb 04 '24 13:02 RenechCDDA

I apologize, it appears I was mistaken. I believed you had locally modified the Bombastic Perks mod which caused this error, because I saw that the enchantment ID was written in Cyrillic (we do not use Cyrillic script normally). This appears to be a real error related to localization.

RenechCDDA avatar Feb 11 '24 17:02 RenechCDDA

This happens for me too. It is very reproducible as it always happens only after I edit any mod (*) json and make mistakes, such as a missing comma between } {, so the game can't start. I fix the mistake, delete the world, make a new one and I get the same "Invalid or misplaced field name "copy-from" in JSON data" on art_robe copy-from, every time.

This is after deleting a comma 1

This is after re-adding the comma, saving the file, deleting the world, creating a new one and going to New Game -> Custom Character 2

The error happens before the "Loading files" window (this one) 3

(*) I just tried to replicate it with a barebones world, no mods. It did not happen:

After deleting a comma before the Survivor profession 4

After re-adding the comma, saving the file, deleting the world, creating a new one and going to New Game -> Custom Character 5

This has been happening to me since at least the 0.G experimentals. Not sure if it's relevant, but I use Fris0uman's launcher. It did not happen to me before 0.G, which coincides when I switched launchers.

Here's my version and config

  • OS: Windows
    • OS Version: 10.0.19044.2965 (21H2)
  • Game Version: 17e0ee6 [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Portal Storms Ignore NPCs [personal_portal_storms], Slowdown Fungal Growth [no_fungal_growth], Touhou Professions [Touhou] ]

RedMisao avatar Feb 11 '24 19:02 RedMisao

This happens for me too. It is very reproducible as it always happens only after I edit any mod (*) json and make mistakes, such as a missing comma between } {, so the game can't start. I fix the mistake, delete the world, make a new one and I get the same "Invalid or misplaced field name "copy-from" in JSON data" on art_robe copy-from, every time.

This is unrelated, the loading process freaks out when you abort in the middle of it, you just need to restart the game. There's an issue for it, somewhere.

RenechCDDA avatar Feb 12 '24 02:02 RenechCDDA

The JSON error stuff should be solved by #72522, which means all issues here have been addressed. For real this time.

RenechCDDA avatar Mar 22 '24 00:03 RenechCDDA