Cataclysm-DDA icon indicating copy to clipboard operation
Cataclysm-DDA copied to clipboard

Concrete Mixer audit

Open Karol1223 opened this issue 1 year ago • 9 comments

Summary

None

Purpose of change

Our tiny tabletop concrete mixer didn't really fit with realism that well

Describe the solution

CONCRETE MIXER ITEM CHANGES
  • Weight increased from ~9kg to ~41kg
  • Volume increased from 5l to 250l
  • Added a manually defined longest side of 118cm
  • Decreased pre-apo price from 500$ to 400$
  • to-hit values now use modifiers
  • Material now has 50% plastic (based on a concrete mixer with a plastic drum)
  • Added an open pocket that can be used to store things
  • Removed the HOTPLATE use action because why the fuck can we heat up lunch in a concrete mixer
  • [EXPERIMENTALLY!] Removed the battery well, the idea is to have it only work when plugged into the grid. We'll see how it goes...
CONCRETE MIXER RECIPE CHANGES
  • No longer takes raw steel, 2l metal tank, or heating elements
  • Will now take 2 small wheels and a 30 gallon plastic barrel
  • Tripled the number of pipes needed
  • No longer has metalworking proficiency
  • Will now take an extension cord instead of a bunch of loose cables
  • Will take a small motor instead of a tiny motor
  • Added some nuts and bolts as per the user manual of the one I'm basing this off
  • Added some small metal sheets (for the blades to mix the concrete as well as to cover the motor)
  • The weld length has been recalculated and increased over four times
  • Now needs a metal sawing quality of 2 instead of 1, multitool won't cut it
30 GALLON PLASTIC BARREL CHANGES
  • Volume increased from ~118l to ~165l
  • Pocket volume increased slightly (by ~1l)
  • Added a manually defined longest side of 72cm
  • Increased pre-apo price from 50$ to 71$
  • Renamed to clearly show it's made of plastic
  • to-hit values now use modifiers
  • Recipe fundamentally changed to be melding the plastic barrel instead of duct-taping plastic jerrycans together (?)
MISC CHANGES
  • Concrete mixer can no longer be attached to the modular rigs (vehicle & appliance)

Describe alternatives you've considered

Testing

Although most of the things work as expected, the PR is blocked by #71108

Additional context

The recipe isn't perfect and generates roughly 7kg of mass, but I cannot make it better without adding bullshit requirements.

Karol1223 avatar Jul 20 '23 13:07 Karol1223

I wouldn't get rid of the battery or modular rig compatibility. It's good to keep options for usage open, that's why microwaves, hotplates, welders etc can run on battery backup. Have you made sure it doesn't cause overflow iin the world due to 1000L space limits?

anoobindisguise avatar Jul 20 '23 17:07 anoobindisguise

I wouldn't get rid of the battery or modular rig compatibility. It's good to keep options for usage open, that's why microwaves, hotplates, welders etc can run on battery backup. Have you made sure it doesn't cause overflow iin the world due to 1000L space limits?

I've not made sure of anything yet, really. Hence the testing disclaimer. I'm not sure how to test it either but we'll burn that bridge when we get there.

As for the first part - I disagree. I am a firm believer in realism. And, frankly, if you're using a concrete mixer for anything the least you can do is have a power grid set up. Again, this warrants further testing and if it doesn't work as intended I'll give it the battery magazine back BUT if it does work as intended I do want to have it function only plugged in. It makes NO sense for a concrete mixer to take batteries.

Besides, I want to test the waters specifically to see how viable items that function only off the grid are. If this works I wanna try some other stuff like table lamps or possibly swapping the microwaves you mentioned to not take batteries anymore either. But that's an issue for future me.

Karol1223 avatar Jul 20 '23 18:07 Karol1223

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

github-actions[bot] avatar Aug 31 '23 22:08 github-actions[bot]

Alright so to highlight what's actually going on with this one - I am stumped at how to handle the crafting recipe so that it doesn't generate mass. That's what's been blocking me from finishing this. As it stands, the crafting recipe generates roughly 30kg of mass if memory serves me right. But it uses accurate ingredients. So where's the issue? Good question! I'd like to know too...

Karol1223 avatar Sep 01 '23 10:09 Karol1223

There are some cordless battery-powered concrete mixers, but they're going to be the kind that is an agitating rod on a handle citation here. These would work by putting your concrete components in a container such as a drum or bucket, and then mixing it within there; all of the stereotypical rotating-drum concrete mixers are going to be either powered by electric cord or by gasoline. We probably should also have gasoline-powered concrete mixers, but battery powered mixers of the type we have in game simply do not exist in any meaningful quantity.

Kanexan avatar Sep 21 '23 15:09 Kanexan

There are some cordless battery-powered concrete mixers, but they're going to be the kind that is an agitating rod on a handle citation here. These would work by putting your concrete components in a container such as a drum or bucket, and then mixing it within there; all of the stereotypical rotating-drum concrete mixers are going to be either powered by electric cord or by gasoline. We probably should also have gasoline-powered concrete mixers, but battery powered mixers of the type we have in game simply do not exist in any meaningful quantity.

I'm gonna be making that an appliance so no gasoline powering for that.

Karol1223 avatar Sep 21 '23 15:09 Karol1223

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A plastoc 100-liter drum of a portable concrete mixer.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

github-actions[bot] avatar Oct 22 '23 12:10 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

github-actions[bot] avatar Dec 31 '23 09:12 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

github-actions[bot] avatar Feb 19 '24 15:02 github-actions[bot]