Cataclysm-DDA icon indicating copy to clipboard operation
Cataclysm-DDA copied to clipboard

Add updated spacebar sidebar files

Open GrandpuhTy opened this issue 2 years ago • 3 comments

Summary

Interface "New upgrades to spacebar sidebar."

image

  1. Adds an overmap element to the sidebar.
  2. Extends the wielded weapon field for more readability, mostly for ammo count.

Purpose of change

A couple of minor QoL tweaks to the spacebar sidebar. As much as I liked the original version it was lacking an overmap and had a UI limitation of the wielded weapon for firearms, namely the name/attachment/ammo count were being cutoff.

Describe the solution

I created a new spacebar_overmap.json file with overmap widgets and tweaked existing widgets in spacebar_environment_block to accommodate the new overmap widget. I also re-arranged the ordering of the martial arts widgets in spacebar_waepon_ma_block to allow for the extended weapon text to be displayed.

Describe alternatives you've considered

Not doing what I did? Create a new folder to retain current edition of spacebar?

Testing

Fresh install on newest experimental. Copied files over. New world new character(henceforth NWNC "Nu-Nic"). Switched to spacebar sidebar. Smile.

Additional context

GrandpuhTy avatar Feb 09 '23 10:02 GrandpuhTy

Note: to make our files style consistent we use this linter. It is a mandatory thing for this project, so please lint your files

GuardianDll avatar Feb 09 '23 11:02 GuardianDll

Note: to make our files style consistent we use this linter. It is a mandatory thing for this project, so please lint your files

Linted the files. I think I did it right. edit: updating the files with the linted versions on github I mean

edit-edit: wait I'm getting some weirdness going on, not sure what's causing the problem: image

GrandpuhTy avatar Feb 09 '23 11:02 GrandpuhTy

Okay false alarm. Just some oddity with copy-pasting over files. Tried deleting the folder and copying a new folder in and no wonkiness.

edit: I gotta stop doing these completely sleep deprived.

GrandpuhTy avatar Feb 09 '23 12:02 GrandpuhTy

Bump?

GrandpuhTy avatar Mar 31 '23 04:03 GrandpuhTy

You might want to rebase to get the tests up to date. Either that or close and re-open the PR.

anothersimulacrum avatar Mar 31 '23 15:03 anothersimulacrum

You might want to rebase to get the tests up to date. Either that or close and re-open the PR.

That work?

GrandpuhTy avatar Mar 31 '23 21:03 GrandpuhTy

Looks good.

anothersimulacrum avatar Apr 01 '23 00:04 anothersimulacrum