Cataclysm-DDA icon indicating copy to clipboard operation
Cataclysm-DDA copied to clipboard

Move place zombie mom to mission JSON

Open cathalpern opened this issue 3 years ago • 7 comments

Summary

None

Purpose of change

In the interest of achieving #3951, this removes the place_zombie_method (and its add_spawn call) and uses the mission templates to place a zombie as the target of the Kill Zombie Mom quest

Describe the solution

Use the now built in JSON-ification of generating mission based objects and monsters instead of the hard coded C++ implementation

Describe alternatives you've considered

Update the hard coded add_spawns in place_zombie_mom to use place_spawns - but that seemed silly

Testing

Assigned start NPC the Kill Zombie Mom quest, went to house, killed zombie mom, verified that NPC was indeed grateful

cathalpern avatar Nov 29 '22 01:11 cathalpern

The only difference is that right now through json we can't give this zombie a random female name. Might need to add this functionality some time in the future.

Night-Pryanik avatar Nov 29 '22 02:11 Night-Pryanik

The only difference is that right now through json we can't give this zombie a random female name. Might need to add this functionality some time in the future.

I guess I could hard code one for now, to at least make it easier to tell what zombie you're supposed to be targeting?

cathalpern avatar Nov 29 '22 03:11 cathalpern

Yeah, as a temporary solution this will suffice.

Night-Pryanik avatar Nov 29 '22 06:11 Night-Pryanik

@cathalpern could you please resolve conflicts?

Night-Pryanik avatar Dec 15 '22 05:12 Night-Pryanik

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

github-actions[bot] avatar Jan 15 '23 00:01 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

github-actions[bot] avatar Feb 14 '23 08:02 github-actions[bot]

need to appease clang and remove the unused var

bombasticSlacks avatar Mar 03 '23 17:03 bombasticSlacks

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

github-actions[bot] avatar May 06 '23 01:05 github-actions[bot]